PromucFlow_constructor/app/client/src/utils/widgetEvalUtils.ts

60 lines
1.7 KiB
TypeScript
Raw Normal View History

chore: query module evaluation (#27660) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description There are multiple refactors and split for query module's creator flow changes which involves module input -- it's a new entity introduced as part of modules project #### PR fixes following issue(s) Fixes # (issue number) Part of https://app.zenhub.com/workspaces/modules-pod-63e0d668a7fea03850c89c6f/issues/gh/appsmithorg/appsmith/27352 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-09-29 10:42:14 +00:00
import type { WidgetEntity } from "@appsmith/entities/DataTree/types";
/**
* PropertyName examples
* - `TableWidget`: column propertyName
* - `JSONForm`: field accessor name
* - `ButtonGroup`: button label name
* - `MenuButton`: button label name
* @param widgetEntity
* @param propertyPath
* @returns
*/
export const isWidgetPropertyNamePath = (
fix: Improving performance of JS evaluations by splitting the data tree (#21547) ## Description This is the second phase of the split data tree. In the previous version, we collected all config paths in each entity and put them in the `__config__` property. All those config properties do get inserted into final data tree which we don't need at all. As part of this change, we will be creating another tree i.e **'configTree'** which will contain all config of each entity. unEvalTree is split into 2 trees => 1. unEvalTree 2. configTree Example: previous unEvalTree Api1 content <img width="1766" alt="image" src="https://user-images.githubusercontent.com/7846888/215990868-0b095421-e7b8-44bc-89aa-065b35e237d6.png"> After this change unEvalTree Api1 content <img width="1758" alt="image" src="https://user-images.githubusercontent.com/7846888/215991045-506fb10a-645a-4aad-8e77-0f3786a86977.png"> Note- above example doesn't have '__config__' property configTree Api1 content <img width="1760" alt="image" src="https://user-images.githubusercontent.com/7846888/215991169-a2e03443-5d6a-4ff1-97c5-a12593e46395.png"> ## Type of change - Chore (housekeeping or task changes that don't impact user perception) - #11351 ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-03-20 11:04:02 +00:00
widgetEntity: WidgetEntity,
fullPath: string,
) => {
switch (widgetEntity.type) {
case "TABLE_WIDGET":
case "TABLE_WIDGET_V2": {
// TableWidget: Table1.primaryColumns.customColumn1.alias
const subPaths = fullPath.split(".");
if (subPaths.length === 4) {
return subPaths[1] === "primaryColumns" && subPaths[3] === "alias";
}
return false;
}
case "BUTTON_GROUP_WIDGET": {
// buttonGroup: ButtonGroup1.groupButtons.groupButton8osb9mezmx.label
const subPaths = fullPath.split(".");
if (subPaths.length === 4) {
return subPaths[1] === "groupButtons" && subPaths[3] === "label";
}
return false;
}
case "JSON_FORM_WIDGET": {
// JSONForm1.schema.__root_schema__.children.customField1.accessor
const subPaths = fullPath.split(".");
if (subPaths.length === 6) {
return (
subPaths[1] === "schema" &&
subPaths[3] === "children" &&
subPaths[5] === "accessor"
);
}
return false;
}
case "MENU_BUTTON_WIDGET": {
// MenuButton1.menuItems.menuItemdcoc16pgml.label
const subPaths = fullPath.split(".");
if (subPaths.length === 4) {
return subPaths[1] === "menuItems" && subPaths[3] === "label";
}
return false;
}
default:
return false;
}
};