2024-12-04 14:13:31 +00:00
|
|
|
import { fork, put, select, call, take } from "redux-saga/effects";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { RouteChangeActionPayload } from "actions/focusHistoryActions";
|
2023-02-21 13:38:16 +00:00
|
|
|
import { FocusEntity, identifyEntityFromPath } from "navigation/FocusEntity";
|
2022-10-17 15:16:38 +00:00
|
|
|
import log from "loglevel";
|
2024-08-06 14:52:22 +00:00
|
|
|
import AnalyticsUtil from "ee/utils/AnalyticsUtil";
|
2022-12-15 04:06:13 +00:00
|
|
|
import { getRecentEntityIds } from "selectors/globalSearchSelectors";
|
2025-01-10 04:51:54 +00:00
|
|
|
import { ReduxActionTypes } from "ee/constants/ReduxActionConstants";
|
|
|
|
|
import { type ReduxAction } from "actions/ReduxActionTypes";
|
2022-12-15 04:06:13 +00:00
|
|
|
import { getCurrentThemeDetails } from "selectors/themeSelectors";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { BackgroundTheme } from "sagas/ThemeSaga";
|
|
|
|
|
import { changeAppBackground } from "sagas/ThemeSaga";
|
2022-12-15 04:06:13 +00:00
|
|
|
import { updateRecentEntitySaga } from "sagas/GlobalSearchSagas";
|
2023-02-21 13:38:16 +00:00
|
|
|
import {
|
|
|
|
|
setLastSelectedWidget,
|
|
|
|
|
setSelectedWidgets,
|
|
|
|
|
} from "actions/widgetSelectionActions";
|
|
|
|
|
import { MAIN_CONTAINER_WIDGET_ID } from "constants/WidgetConstants";
|
2024-01-08 05:39:47 +00:00
|
|
|
import FocusRetention from "sagas/FocusRetentionSaga";
|
2023-04-06 06:20:35 +00:00
|
|
|
import { getSafeCrash } from "selectors/errorSelectors";
|
|
|
|
|
import { flushErrors } from "actions/errorActions";
|
2023-04-10 07:25:14 +00:00
|
|
|
import type { NavigationMethod } from "utils/history";
|
2023-08-11 11:34:42 +00:00
|
|
|
import UsagePulse from "usagePulse";
|
2024-08-06 14:52:22 +00:00
|
|
|
import { getIDETypeByUrl } from "ee/entities/IDE/utils";
|
|
|
|
|
import type { EditorViewMode } from "ee/entities/IDE/constants";
|
|
|
|
|
import { IDE_TYPE } from "ee/entities/IDE/constants";
|
2024-01-23 04:52:50 +00:00
|
|
|
import { updateIDETabsOnRouteChangeSaga } from "sagas/IDESaga";
|
2024-03-12 13:13:00 +00:00
|
|
|
import { getIDEViewMode } from "selectors/ideSelectors";
|
2022-10-17 15:16:38 +00:00
|
|
|
|
|
|
|
|
let previousPath: string;
|
2022-12-15 04:06:13 +00:00
|
|
|
|
2023-01-10 00:25:39 +00:00
|
|
|
export function* handleRouteChange(
|
|
|
|
|
action: ReduxAction<RouteChangeActionPayload>,
|
2022-10-17 15:16:38 +00:00
|
|
|
) {
|
2023-02-21 13:38:16 +00:00
|
|
|
const { pathname, state } = action.payload.location;
|
2024-09-18 16:35:28 +00:00
|
|
|
|
2022-10-17 15:16:38 +00:00
|
|
|
try {
|
2023-04-06 06:20:35 +00:00
|
|
|
yield fork(clearErrors);
|
2023-08-11 11:34:42 +00:00
|
|
|
yield fork(watchForTrackableUrl, action.payload);
|
2025-01-29 08:26:00 +00:00
|
|
|
const IDEType = getIDETypeByUrl(pathname);
|
|
|
|
|
|
2025-02-05 06:53:42 +00:00
|
|
|
if (previousPath) {
|
|
|
|
|
yield fork(
|
|
|
|
|
FocusRetention.onRouteChange.bind(FocusRetention),
|
|
|
|
|
pathname,
|
|
|
|
|
previousPath,
|
|
|
|
|
state,
|
|
|
|
|
);
|
|
|
|
|
}
|
2025-01-29 08:26:00 +00:00
|
|
|
|
|
|
|
|
if (IDEType === IDE_TYPE.App) {
|
|
|
|
|
yield fork(logNavigationAnalytics, action.payload);
|
|
|
|
|
yield fork(appBackgroundHandler);
|
|
|
|
|
const entityInfo = identifyEntityFromPath(pathname);
|
|
|
|
|
|
|
|
|
|
yield fork(updateRecentEntitySaga, entityInfo);
|
|
|
|
|
yield fork(updateIDETabsOnRouteChangeSaga, entityInfo);
|
|
|
|
|
yield fork(setSelectedWidgetsSaga, state?.invokedBy);
|
2022-12-26 07:10:09 +00:00
|
|
|
}
|
2022-10-17 15:16:38 +00:00
|
|
|
} catch (e) {
|
|
|
|
|
log.error("Error in focus change", e);
|
|
|
|
|
} finally {
|
|
|
|
|
previousPath = pathname;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-02-21 13:38:16 +00:00
|
|
|
function* appBackgroundHandler() {
|
|
|
|
|
const currentTheme: BackgroundTheme = yield select(getCurrentThemeDetails);
|
2024-09-18 16:35:28 +00:00
|
|
|
|
2023-02-21 13:38:16 +00:00
|
|
|
changeAppBackground(currentTheme);
|
|
|
|
|
}
|
|
|
|
|
|
2023-04-06 06:20:35 +00:00
|
|
|
/**
|
|
|
|
|
* When an error occurs, we take over the whole router and keep it the error
|
|
|
|
|
* state till the errors are flushed. By default, we will flush out the
|
|
|
|
|
* error state when a CTA on the page is clicked but in case the
|
|
|
|
|
* user navigates via the browser buttons, this will ensure
|
|
|
|
|
* the errors are flushed
|
|
|
|
|
* */
|
|
|
|
|
function* clearErrors() {
|
|
|
|
|
const isCrashed: boolean = yield select(getSafeCrash);
|
2024-09-18 16:35:28 +00:00
|
|
|
|
2023-04-06 06:20:35 +00:00
|
|
|
if (isCrashed) {
|
|
|
|
|
yield put(flushErrors());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-08-11 11:34:42 +00:00
|
|
|
function* watchForTrackableUrl(payload: RouteChangeActionPayload) {
|
2024-12-04 14:13:31 +00:00
|
|
|
yield take([
|
|
|
|
|
ReduxActionTypes.INITIALIZE_EDITOR_SUCCESS,
|
|
|
|
|
ReduxActionTypes.INITIALIZE_PAGE_VIEWER_SUCCESS,
|
|
|
|
|
]);
|
2023-08-11 11:34:42 +00:00
|
|
|
const oldPathname = payload.prevLocation.pathname;
|
|
|
|
|
const newPathname = payload.location.pathname;
|
|
|
|
|
const isOldPathTrackable: boolean = yield call(
|
|
|
|
|
UsagePulse.isTrackableUrl,
|
|
|
|
|
oldPathname,
|
|
|
|
|
);
|
|
|
|
|
const isNewPathTrackable: boolean = yield call(
|
|
|
|
|
UsagePulse.isTrackableUrl,
|
|
|
|
|
newPathname,
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
// Trackable to Trackable URL -> No pulse
|
|
|
|
|
// Non-Trackable to Non-Trackable URL -> No pulse
|
|
|
|
|
// Trackable to Non-Trackable -> No Pulse
|
|
|
|
|
// Non-Trackable to Trackable URL -> Send Pulse
|
|
|
|
|
|
|
|
|
|
if (!isOldPathTrackable && isNewPathTrackable) {
|
|
|
|
|
yield call(UsagePulse.sendPulseAndScheduleNext);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-03-30 05:33:29 +00:00
|
|
|
function* logNavigationAnalytics(payload: RouteChangeActionPayload) {
|
2022-12-15 04:06:13 +00:00
|
|
|
const {
|
2023-02-21 13:38:16 +00:00
|
|
|
location: { pathname, state },
|
2022-12-15 04:06:13 +00:00
|
|
|
} = payload;
|
|
|
|
|
const recentEntityIds: Array<string> = yield select(getRecentEntityIds);
|
2023-02-21 13:38:16 +00:00
|
|
|
const currentEntity = identifyEntityFromPath(pathname);
|
|
|
|
|
const previousEntity = identifyEntityFromPath(previousPath);
|
2022-12-15 04:06:13 +00:00
|
|
|
const isRecent = recentEntityIds.some(
|
|
|
|
|
(entityId) => entityId === currentEntity.id,
|
|
|
|
|
);
|
2024-03-12 13:13:00 +00:00
|
|
|
const ideViewMode: EditorViewMode = yield select(getIDEViewMode);
|
2023-07-24 07:41:47 +00:00
|
|
|
const { height, width } = window.screen;
|
2024-09-18 16:35:28 +00:00
|
|
|
|
2022-12-15 04:06:13 +00:00
|
|
|
AnalyticsUtil.logEvent("ROUTE_CHANGE", {
|
2023-02-21 13:38:16 +00:00
|
|
|
toPath: pathname,
|
|
|
|
|
fromPath: previousPath || undefined,
|
2022-12-15 04:06:13 +00:00
|
|
|
navigationMethod: state?.invokedBy,
|
|
|
|
|
isRecent,
|
|
|
|
|
recentLength: recentEntityIds.length,
|
|
|
|
|
toType: currentEntity.entity,
|
|
|
|
|
fromType: previousEntity.entity,
|
2023-07-24 07:41:47 +00:00
|
|
|
screenHeight: height,
|
|
|
|
|
screenWidth: width,
|
2024-03-12 13:13:00 +00:00
|
|
|
editorMode: ideViewMode,
|
2022-12-15 04:06:13 +00:00
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
|
2023-04-10 07:25:14 +00:00
|
|
|
function* setSelectedWidgetsSaga(invokedBy?: NavigationMethod) {
|
2023-02-21 13:38:16 +00:00
|
|
|
const pathname = window.location.pathname;
|
|
|
|
|
const entityInfo = identifyEntityFromPath(pathname);
|
|
|
|
|
let widgets: string[] = [];
|
|
|
|
|
let lastSelectedWidget = MAIN_CONTAINER_WIDGET_ID;
|
2024-09-18 16:35:28 +00:00
|
|
|
|
2025-01-29 08:26:00 +00:00
|
|
|
if (entityInfo.entity === FocusEntity.WIDGET) {
|
2023-02-21 13:38:16 +00:00
|
|
|
widgets = entityInfo.id.split(",");
|
2024-09-18 16:35:28 +00:00
|
|
|
|
2023-02-21 13:38:16 +00:00
|
|
|
if (widgets.length) {
|
|
|
|
|
lastSelectedWidget = widgets[widgets.length - 1];
|
2023-01-28 02:17:06 +00:00
|
|
|
}
|
|
|
|
|
}
|
2024-09-18 16:35:28 +00:00
|
|
|
|
2023-04-10 07:25:14 +00:00
|
|
|
yield put(setSelectedWidgets(widgets, invokedBy));
|
2023-02-21 13:38:16 +00:00
|
|
|
yield put(setLastSelectedWidget(lastSelectedWidget));
|
2022-10-17 15:16:38 +00:00
|
|
|
}
|