PromucFlow_constructor/app/client/src/utils/testPropertyPaneConfig.test.ts

196 lines
6.4 KiB
TypeScript
Raw Normal View History

chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> ## Description This PR upgrades Prettier to v2 + enforces TypeScript’s [`import type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export) syntax where applicable. It’s submitted as a separate PR so we can merge it easily. As a part of this PR, we reformat the codebase heavily: - add `import type` everywhere where it’s required, and - re-format the code to account for Prettier 2’s breaking changes: https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes This PR is submitted against `release` to make sure all new code by team members will adhere to new formatting standards, and we’ll have fewer conflicts when merging `bundle-optimizations` into `release`. (I’ll merge `release` back into `bundle-optimizations` once this PR is merged.) ### Why is this needed? This PR is needed because, for the Lodash optimization from https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3, we need to use `import type`. Otherwise, `babel-plugin-lodash` complains that `LoDashStatic` is not a lodash function. However, just using `import type` in the current codebase will give you this: <img width="962" alt="Screenshot 2023-03-08 at 17 45 59" src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png"> That’s because Prettier 1 can’t parse `import type` at all. To parse it, we need to upgrade to Prettier 2. ### Why enforce `import type`? Apart from just enabling `import type` support, this PR enforces specifying `import type` everywhere it’s needed. (Developers will get immediate TypeScript and ESLint errors when they forget to do so.) I’m doing this because I believe `import type` improves DX and makes refactorings easier. Let’s say you had a few imports like below. Can you tell which of these imports will increase the bundle size? (Tip: it’s not all of them!) ```ts // app/client/src/workers/Linting/utils.ts import { Position } from "codemirror"; import { LintError as JSHintError, LintOptions } from "jshint"; import { get, isEmpty, isNumber, keys, last, set } from "lodash"; ``` It’s pretty hard, right? What about now? ```ts // app/client/src/workers/Linting/utils.ts import type { Position } from "codemirror"; import type { LintError as JSHintError, LintOptions } from "jshint"; import { get, isEmpty, isNumber, keys, last, set } from "lodash"; ``` Now, it’s clear that only `lodash` will be bundled. This helps developers to see which imports are problematic, but it _also_ helps with refactorings. Now, if you want to see where `codemirror` is bundled, you can just grep for `import \{.*\} from "codemirror"` – and you won’t get any type-only imports. This also helps (some) bundlers. Upon transpiling, TypeScript erases type-only imports completely. In some environment (not ours), this makes the bundle smaller, as the bundler doesn’t need to bundle type-only imports anymore. ## Type of change - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? This was tested to not break the build. ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
import type {
PropertyPaneConfig,
PropertyPaneControlConfig,
2022-12-11 14:42:32 +00:00
PropertyPaneSectionConfig,
ValidationConfig,
} from "constants/PropertyControlConstants";
import { ValidationTypes } from "constants/WidgetValidation";
2022-12-11 14:42:32 +00:00
import { isFunction } from "lodash";
import WidgetFactory from "utils/WidgetFactory";
import { ALL_WIDGETS_AND_CONFIG, registerWidgets } from "./WidgetRegistry";
function validatePropertyPaneConfig(
config: PropertyPaneConfig[],
isWidgetHidden: boolean,
) {
for (const sectionOrControlConfig of config) {
2022-12-11 14:42:32 +00:00
const sectionConfig = sectionOrControlConfig as PropertyPaneSectionConfig;
if (sectionConfig.sectionName && isFunction(sectionConfig.sectionName)) {
return ` SectionName should be a string and not a function. Search won't work for functions at the moment`;
}
if (sectionOrControlConfig.children) {
for (const propertyControlConfig of sectionOrControlConfig.children) {
const propertyControlValidation = validatePropertyControl(
propertyControlConfig,
isWidgetHidden,
);
if (propertyControlValidation !== true)
return propertyControlValidation;
}
}
}
return true;
}
function validatePropertyControl(
config: PropertyPaneConfig,
isWidgetHidden: boolean,
): boolean | string {
const _config = config as PropertyPaneControlConfig;
const controls = ["INPUT_TEXT"];
2022-12-11 14:42:32 +00:00
if (_config.label && isFunction(_config.label)) {
return `${_config.propertyName}: Label should be a string and not a function. Search won't work for functions at the moment`;
}
if (
!isWidgetHidden &&
_config.label &&
!_config.invisible &&
feat: List V2 (#15839) ## Description TL;DR This is a complete architectural change of of List widget works to support all widgets we currently have and should automatically support any future widgets. It also introduces nested List widgets i.e a list widget can have a another list widget which in turn can have another list widget. Fixes #18206 Fixes #6775 Fixes #13211 Fixes #16582 Fixes #11739 Fixes #15094 Fixes #6840 Fixes #10841 Fixes #17386 Fixes #18340 Fixes #16898 Fixes #17555 Fixes #6858 Fixes #9568 Fixes #17480 Fixes #18523 Fixes #18206 Fixes #16586 Fixes #18106 Fixes #16576 Fixes #14697 Fixes #9607 Fixes #19648 Fixes #19739 Fixes #19652 Fixes #18730 Fixes #19503 Fixes #19498 Fixes #19437 Fixes #5245 Fixes #19150 Fixes #18638 Fixes #11332 Fixes #17901 Fixes #19043 Fixes #17777 Fixes #8237 Fixes #15487 Fixes #15988 Fixes #18621 Fixes #16788 Fixes #18110 Fixes #18382 Fixes #17427 Fixes #18105 Fixes #18287 Fixes #19808 Fixes #14655 ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Cypress - Jest - Manual ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes --------- Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com> Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
2023-02-14 16:07:31 +00:00
!(_config.helpText || _config.helperText)
) {
feat: List V2 (#15839) ## Description TL;DR This is a complete architectural change of of List widget works to support all widgets we currently have and should automatically support any future widgets. It also introduces nested List widgets i.e a list widget can have a another list widget which in turn can have another list widget. Fixes #18206 Fixes #6775 Fixes #13211 Fixes #16582 Fixes #11739 Fixes #15094 Fixes #6840 Fixes #10841 Fixes #17386 Fixes #18340 Fixes #16898 Fixes #17555 Fixes #6858 Fixes #9568 Fixes #17480 Fixes #18523 Fixes #18206 Fixes #16586 Fixes #18106 Fixes #16576 Fixes #14697 Fixes #9607 Fixes #19648 Fixes #19739 Fixes #19652 Fixes #18730 Fixes #19503 Fixes #19498 Fixes #19437 Fixes #5245 Fixes #19150 Fixes #18638 Fixes #11332 Fixes #17901 Fixes #19043 Fixes #17777 Fixes #8237 Fixes #15487 Fixes #15988 Fixes #18621 Fixes #16788 Fixes #18110 Fixes #18382 Fixes #17427 Fixes #18105 Fixes #18287 Fixes #19808 Fixes #14655 ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Cypress - Jest - Manual ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes --------- Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com> Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
2023-02-14 16:07:31 +00:00
return `${_config.propertyName} (${_config.label}): Help text or Helper textis mandatory for property controls`;
}
if (
(_config.isJSConvertible || controls.includes(_config.controlType)) &&
!_config.isTriggerProperty
) {
if (!_config.isBindProperty)
return `${
_config.propertyName
}: isBindProperty should be true if isJSConvertible is true or when control type is [${controls.join(
" | ",
)}]`;
if (!_config.validation)
return `${
_config.propertyName
}: validation should be defined if isJSConvertible is true or when control type is [${controls.join(
" | ",
)}]`;
}
if (controls.includes(_config.controlType) && _config.isJSConvertible) {
return `${
_config.propertyName
}: No need of setting isJSConvertible since users can write JS inside [${controls.join(
" | ",
)}]`;
}
if (_config.validation !== undefined) {
const res = validateValidationStructure(_config.validation);
if (res !== true) return `${_config.propertyName}: ${res}`;
}
if (_config.children) {
for (const child of _config.children) {
const res = validatePropertyControl(child, isWidgetHidden);
if (res !== true) return `${_config.propertyName}.${res}`;
}
}
if (_config.panelConfig) {
if (_config.panelConfig.children) {
const res = validatePropertyPaneConfig(
_config.panelConfig.children,
isWidgetHidden,
);
if (res !== true) return `${_config.propertyName}.${res}`;
}
if (_config.panelConfig.contentChildren) {
const res = validatePropertyPaneConfig(
_config.panelConfig.contentChildren,
isWidgetHidden,
);
if (res !== true) return `${_config.propertyName}.${res}`;
}
if (_config.panelConfig.styleChildren) {
const res = validatePropertyPaneConfig(
_config.panelConfig.styleChildren,
isWidgetHidden,
);
if (res !== true) return `${_config.propertyName}.${res}`;
}
}
return true;
}
function validateValidationStructure(
config: ValidationConfig,
): boolean | string {
if (
config.type === ValidationTypes.FUNCTION &&
config.params &&
config.params.fn
) {
if (!config.params.expected)
return `For a ${ValidationTypes.FUNCTION} type validation, expected type and example are mandatory`;
}
return true;
}
const isNotFloat = (n: any) => {
return Number(n) === n && n % 1 === 0;
};
describe("Tests all widget's propertyPane config", () => {
beforeAll(() => {
registerWidgets();
});
ALL_WIDGETS_AND_CONFIG.forEach((widgetAndConfig) => {
const [widget, config]: any = widgetAndConfig;
it(`Checks ${widget.getWidgetType()}'s propertyPaneConfig`, () => {
const propertyPaneConfig = widget.getPropertyPaneConfig();
expect(
validatePropertyPaneConfig(propertyPaneConfig, config.hideCard),
).toStrictEqual(true);
const propertyPaneContentConfig = widget.getPropertyPaneContentConfig();
expect(
validatePropertyPaneConfig(
propertyPaneContentConfig,
config.isDeprecated,
),
).toStrictEqual(true);
const propertyPaneStyleConfig = widget.getPropertyPaneStyleConfig();
expect(
validatePropertyPaneConfig(
propertyPaneStyleConfig,
config.isDeprecated,
),
).toStrictEqual(true);
});
it(`Check if ${widget.getWidgetType()}'s dimensions are always integers`, () => {
expect(isNotFloat(config.defaults.rows)).toBe(true);
expect(isNotFloat(config.defaults.columns)).toBe(true);
});
if (config.isDeprecated) {
it(`Check if ${widget.getWidgetType()}'s deprecation config has a proper replacement Widget`, () => {
const widgetType = widget.getWidgetType();
if (config.replacement === undefined) {
fail(`${widgetType}'s replacement widget is not defined`);
}
const replacementWidgetType = config.replacement;
const replacementWidgetConfig = WidgetFactory.widgetConfigMap.get(
replacementWidgetType,
);
if (replacementWidgetConfig === undefined) {
fail(
`${widgetType}'s replacement widget ${replacementWidgetType} does not resolve to an actual widget Config`,
);
}
if (replacementWidgetConfig?.isDeprecated) {
fail(
`${widgetType}'s replacement widget ${replacementWidgetType} itself is deprecated. Cannot have a deprecated widget as a replacement for another deprecated widget`,
);
}
if (replacementWidgetConfig?.hideCard) {
fail(
`${widgetType}'s replacement widget ${replacementWidgetType} should be available in the entity Explorer`,
);
}
});
}
});
});