chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { ReduxAction } from "@appsmith/constants/ReduxActionConstants";
|
2021-07-20 10:02:56 +00:00
|
|
|
import {
|
|
|
|
|
ReduxActionErrorTypes,
|
|
|
|
|
ReduxActionTypes,
|
2022-04-12 10:50:01 +00:00
|
|
|
} from "@appsmith/constants/ReduxActionConstants";
|
2023-07-05 13:34:03 +00:00
|
|
|
import { intersection, union } from "lodash";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { DependencyMap } from "utils/DynamicBindingUtils";
|
|
|
|
|
import type { QueryActionConfig } from "entities/Action";
|
2023-04-24 04:40:47 +00:00
|
|
|
import type { DatasourceConfiguration } from "entities/Datasource";
|
2023-08-16 05:34:32 +00:00
|
|
|
import type { DiffWithReferenceState } from "workers/Evaluation/helpers";
|
2021-07-20 10:02:56 +00:00
|
|
|
|
|
|
|
|
export const FIRST_EVAL_REDUX_ACTIONS = [
|
|
|
|
|
// Pages
|
2022-06-06 03:56:14 +00:00
|
|
|
ReduxActionTypes.FETCH_ALL_PAGE_ENTITY_COMPLETION,
|
2021-07-20 10:02:56 +00:00
|
|
|
];
|
2022-06-10 18:22:59 +00:00
|
|
|
|
2022-11-03 09:23:15 +00:00
|
|
|
export const LINT_REDUX_ACTIONS = {
|
|
|
|
|
[ReduxActionTypes.FETCH_ALL_PAGE_ENTITY_COMPLETION]: true,
|
|
|
|
|
[ReduxActionTypes.CREATE_ACTION_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.UPDATE_ACTION_PROPERTY]: true,
|
|
|
|
|
[ReduxActionTypes.DELETE_ACTION_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.COPY_ACTION_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.MOVE_ACTION_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.CREATE_JS_ACTION_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.DELETE_JS_ACTION_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.COPY_JS_ACTION_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.MOVE_JS_ACTION_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.SET_USER_CURRENT_GEO_LOCATION]: true,
|
|
|
|
|
[ReduxActionTypes.UPDATE_LAYOUT]: true,
|
|
|
|
|
[ReduxActionTypes.UPDATE_WIDGET_PROPERTY]: true,
|
|
|
|
|
[ReduxActionTypes.UPDATE_WIDGET_NAME_SUCCESS]: true,
|
2023-07-05 13:34:03 +00:00
|
|
|
[ReduxActionTypes.UPDATE_JS_ACTION_BODY_INIT]: true, // "lint only" action
|
2023-03-09 07:12:54 +00:00
|
|
|
[ReduxActionTypes.META_UPDATE_DEBOUNCED_EVAL]: true,
|
2023-07-05 13:34:03 +00:00
|
|
|
[ReduxActionTypes.FETCH_JS_ACTIONS_FOR_PAGE_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.FETCH_ACTIONS_FOR_PAGE_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.INSTALL_LIBRARY_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.UNINSTALL_LIBRARY_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.BUFFERED_ACTION]: true,
|
|
|
|
|
[ReduxActionTypes.BATCH_UPDATES_SUCCESS]: true,
|
2022-11-03 09:23:15 +00:00
|
|
|
};
|
|
|
|
|
|
2023-04-14 09:14:53 +00:00
|
|
|
export const LOG_REDUX_ACTIONS = {
|
|
|
|
|
[ReduxActionTypes.UPDATE_LAYOUT]: true,
|
|
|
|
|
[ReduxActionTypes.UPDATE_WIDGET_PROPERTY]: true,
|
|
|
|
|
[ReduxActionTypes.UPDATE_WIDGET_NAME_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.CREATE_ACTION_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.UPDATE_ACTION_PROPERTY]: true,
|
|
|
|
|
};
|
2023-03-24 10:15:11 +00:00
|
|
|
|
2021-07-20 10:02:56 +00:00
|
|
|
export const EVALUATE_REDUX_ACTIONS = [
|
|
|
|
|
...FIRST_EVAL_REDUX_ACTIONS,
|
|
|
|
|
// Actions
|
|
|
|
|
ReduxActionTypes.FETCH_PLUGIN_FORM_CONFIGS_SUCCESS,
|
|
|
|
|
ReduxActionTypes.FETCH_ACTIONS_VIEW_MODE_SUCCESS,
|
|
|
|
|
ReduxActionErrorTypes.FETCH_ACTIONS_ERROR,
|
|
|
|
|
ReduxActionErrorTypes.FETCH_ACTIONS_VIEW_MODE_ERROR,
|
|
|
|
|
ReduxActionTypes.FETCH_ACTIONS_FOR_PAGE_SUCCESS,
|
|
|
|
|
ReduxActionTypes.SUBMIT_CURL_FORM_SUCCESS,
|
|
|
|
|
ReduxActionTypes.CREATE_ACTION_SUCCESS,
|
|
|
|
|
ReduxActionTypes.UPDATE_ACTION_PROPERTY,
|
|
|
|
|
ReduxActionTypes.DELETE_ACTION_SUCCESS,
|
|
|
|
|
ReduxActionTypes.COPY_ACTION_SUCCESS,
|
|
|
|
|
ReduxActionTypes.MOVE_ACTION_SUCCESS,
|
|
|
|
|
ReduxActionTypes.RUN_ACTION_SUCCESS,
|
|
|
|
|
ReduxActionErrorTypes.RUN_ACTION_ERROR,
|
2021-08-27 09:25:28 +00:00
|
|
|
ReduxActionTypes.EXECUTE_PLUGIN_ACTION_SUCCESS,
|
|
|
|
|
ReduxActionErrorTypes.EXECUTE_PLUGIN_ACTION_ERROR,
|
|
|
|
|
ReduxActionTypes.CLEAR_ACTION_RESPONSE,
|
2021-09-08 17:32:22 +00:00
|
|
|
// JS Actions
|
|
|
|
|
ReduxActionTypes.CREATE_JS_ACTION_SUCCESS,
|
|
|
|
|
ReduxActionTypes.DELETE_JS_ACTION_SUCCESS,
|
|
|
|
|
ReduxActionTypes.COPY_JS_ACTION_SUCCESS,
|
|
|
|
|
ReduxActionTypes.MOVE_JS_ACTION_SUCCESS,
|
|
|
|
|
ReduxActionErrorTypes.FETCH_JS_ACTIONS_ERROR,
|
|
|
|
|
ReduxActionTypes.FETCH_JS_ACTIONS_FOR_PAGE_SUCCESS,
|
|
|
|
|
ReduxActionTypes.FETCH_JS_ACTIONS_VIEW_MODE_SUCCESS,
|
|
|
|
|
ReduxActionErrorTypes.FETCH_JS_ACTIONS_VIEW_MODE_ERROR,
|
2021-11-08 06:49:22 +00:00
|
|
|
ReduxActionTypes.UPDATE_JS_ACTION_BODY_SUCCESS,
|
2022-12-30 12:31:08 +00:00
|
|
|
ReduxActionTypes.SET_JS_FUNCTION_EXECUTION_DATA,
|
2021-07-20 10:02:56 +00:00
|
|
|
// App Data
|
|
|
|
|
ReduxActionTypes.SET_APP_MODE,
|
|
|
|
|
ReduxActionTypes.FETCH_USER_DETAILS_SUCCESS,
|
2023-01-10 04:53:08 +00:00
|
|
|
ReduxActionTypes.UPDATE_APP_STORE,
|
2021-12-07 10:19:33 +00:00
|
|
|
ReduxActionTypes.SET_USER_CURRENT_GEO_LOCATION,
|
2021-07-20 10:02:56 +00:00
|
|
|
// Widgets
|
|
|
|
|
ReduxActionTypes.UPDATE_LAYOUT,
|
|
|
|
|
ReduxActionTypes.UPDATE_WIDGET_PROPERTY,
|
|
|
|
|
ReduxActionTypes.UPDATE_WIDGET_NAME_SUCCESS,
|
2023-02-14 16:07:31 +00:00
|
|
|
// Meta Widgets
|
|
|
|
|
ReduxActionTypes.MODIFY_META_WIDGETS,
|
|
|
|
|
ReduxActionTypes.DELETE_META_WIDGETS,
|
2021-07-20 10:02:56 +00:00
|
|
|
// Widget Meta
|
2022-05-25 09:46:14 +00:00
|
|
|
ReduxActionTypes.SET_META_PROP_AND_EVAL,
|
|
|
|
|
ReduxActionTypes.META_UPDATE_DEBOUNCED_EVAL,
|
2021-07-20 10:02:56 +00:00
|
|
|
ReduxActionTypes.RESET_WIDGET_META,
|
|
|
|
|
// Batches
|
|
|
|
|
ReduxActionTypes.BATCH_UPDATES_SUCCESS,
|
2022-05-04 09:45:57 +00:00
|
|
|
// App Theme
|
|
|
|
|
ReduxActionTypes.UPDATE_SELECTED_APP_THEME_SUCCESS,
|
|
|
|
|
ReduxActionTypes.CHANGE_SELECTED_APP_THEME_SUCCESS,
|
|
|
|
|
ReduxActionTypes.SET_PREVIEW_APP_THEME,
|
2023-07-05 13:34:03 +00:00
|
|
|
|
|
|
|
|
// Custom Library
|
|
|
|
|
ReduxActionTypes.INSTALL_LIBRARY_SUCCESS,
|
|
|
|
|
ReduxActionTypes.UNINSTALL_LIBRARY_SUCCESS,
|
|
|
|
|
// Buffer
|
|
|
|
|
ReduxActionTypes.BUFFERED_ACTION,
|
2021-07-20 10:02:56 +00:00
|
|
|
];
|
2022-05-25 09:46:14 +00:00
|
|
|
// Topics used for datasource and query form evaluations
|
2022-01-06 10:49:01 +00:00
|
|
|
export const FORM_EVALUATION_REDUX_ACTIONS = [
|
|
|
|
|
ReduxActionTypes.INIT_FORM_EVALUATION,
|
|
|
|
|
ReduxActionTypes.RUN_FORM_EVALUATION,
|
|
|
|
|
];
|
2023-07-05 13:34:03 +00:00
|
|
|
|
|
|
|
|
export const shouldTriggerEvaluation = (action: ReduxAction<unknown>) => {
|
|
|
|
|
return (
|
|
|
|
|
shouldProcessAction(action) && EVALUATE_REDUX_ACTIONS.includes(action.type)
|
|
|
|
|
);
|
|
|
|
|
};
|
|
|
|
|
export const shouldTriggerLinting = (action: ReduxAction<unknown>) => {
|
|
|
|
|
return shouldProcessAction(action) && !!LINT_REDUX_ACTIONS[action.type];
|
2021-07-20 10:02:56 +00:00
|
|
|
};
|
|
|
|
|
|
2023-07-05 13:34:03 +00:00
|
|
|
export const getAllActionTypes = (action: ReduxAction<unknown>) => {
|
2022-11-03 09:23:15 +00:00
|
|
|
if (
|
|
|
|
|
action.type === ReduxActionTypes.BATCH_UPDATES_SUCCESS &&
|
|
|
|
|
Array.isArray(action.payload)
|
|
|
|
|
) {
|
|
|
|
|
const batchedActionTypes = action.payload.map(
|
2023-07-05 13:34:03 +00:00
|
|
|
(batchedAction) => batchedAction.type as string,
|
2022-11-03 09:23:15 +00:00
|
|
|
);
|
2023-07-05 13:34:03 +00:00
|
|
|
return batchedActionTypes;
|
2022-11-03 09:23:15 +00:00
|
|
|
}
|
2023-07-05 13:34:03 +00:00
|
|
|
return [action.type];
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
export const shouldProcessAction = (action: ReduxAction<unknown>) => {
|
|
|
|
|
const actionTypes = getAllActionTypes(action);
|
|
|
|
|
|
|
|
|
|
return intersection(EVAL_AND_LINT_REDUX_ACTIONS, actionTypes).length > 0;
|
|
|
|
|
};
|
2022-11-03 09:23:15 +00:00
|
|
|
|
2023-03-24 10:15:11 +00:00
|
|
|
export function shouldLog(action: ReduxAction<unknown>) {
|
2023-04-14 09:14:53 +00:00
|
|
|
if (
|
|
|
|
|
action.type === ReduxActionTypes.BATCH_UPDATES_SUCCESS &&
|
|
|
|
|
Array.isArray(action.payload)
|
|
|
|
|
) {
|
|
|
|
|
const batchedActionTypes = action.payload.map(
|
|
|
|
|
(batchedAction) => batchedAction.type,
|
|
|
|
|
);
|
|
|
|
|
return batchedActionTypes.some(
|
|
|
|
|
(actionType) => LOG_REDUX_ACTIONS[actionType],
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return LOG_REDUX_ACTIONS[action.type];
|
2023-03-24 10:15:11 +00:00
|
|
|
}
|
|
|
|
|
|
2021-07-20 10:02:56 +00:00
|
|
|
export const setEvaluatedTree = (
|
2023-08-16 05:34:32 +00:00
|
|
|
updates: DiffWithReferenceState[],
|
|
|
|
|
): ReduxAction<{ updates: DiffWithReferenceState[] }> => {
|
2021-07-20 10:02:56 +00:00
|
|
|
return {
|
|
|
|
|
type: ReduxActionTypes.SET_EVALUATED_TREE,
|
2022-05-25 09:46:14 +00:00
|
|
|
payload: { updates },
|
2021-07-20 10:02:56 +00:00
|
|
|
};
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
export const setDependencyMap = (
|
|
|
|
|
inverseDependencyMap: DependencyMap,
|
|
|
|
|
): ReduxAction<{ inverseDependencyMap: DependencyMap }> => {
|
|
|
|
|
return {
|
|
|
|
|
type: ReduxActionTypes.SET_EVALUATION_INVERSE_DEPENDENCY_MAP,
|
|
|
|
|
payload: { inverseDependencyMap },
|
|
|
|
|
};
|
|
|
|
|
};
|
2021-08-26 05:37:07 +00:00
|
|
|
|
|
|
|
|
// Called when a form is being setup, for setting up the base condition evaluations for the form
|
|
|
|
|
export const initFormEvaluations = (
|
|
|
|
|
editorConfig: any,
|
|
|
|
|
settingConfig: any,
|
|
|
|
|
formId: string,
|
|
|
|
|
) => {
|
|
|
|
|
return {
|
|
|
|
|
type: ReduxActionTypes.INIT_FORM_EVALUATION,
|
|
|
|
|
payload: { editorConfig, settingConfig, formId },
|
|
|
|
|
};
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
// Called when there is change in the data of the form, re evaluates the whole form
|
|
|
|
|
export const startFormEvaluations = (
|
|
|
|
|
formId: string,
|
|
|
|
|
formData: QueryActionConfig,
|
2022-02-27 03:32:36 +00:00
|
|
|
datasourceId: string,
|
|
|
|
|
pluginId: string,
|
feat: Simplified Google Sheets queries (#14869)
* Client changes 1
* add DSL functionality
* Temp commit for refactoring changes
* Do I even know what I'm doing here?
* chore: Second GS layout
* Update: Visibility conditional outputs for schemas
- Added the output from conditional outputs for schema children too
* Update: Entity selector visibility control
- Added logic for controlling visibility of sub components via the JS expressions system
* Update: Passing disabled prop to toggle button
* Update: Passing disabled prop to toggle btn
* Update: Styled component for toggle button
- Added disabled styles based on the disabled prop sent to the toggle form view JSON button
* Update: configProperty role in Entity Selector
- Removed dependance of the configProperty of the entity selector children to it's parent component
* Update: type of placeholder key
- Made placeholder key from form config JSON to accept either string or an object
- Earlier only string was accepted
- This is for pagination component
* Update: Added placeholder control for pagination
* Client changes 1
* add DSL functionality
* Do I even know what I'm doing here?
* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design
* fix: updated tooltip component for wrong ui on entity explore
* temp triggers
* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design (#12395)
* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design
* fix: updated tooltip component for wrong ui on entity explore
* fix: updated tooltip ui, where condition placement, sort by ui
* temp form data access logic
* fix: updated sorting type width ui
* fix: updated ui for spacing, width and text issues
* Update: Type for tooltip of UQI forms
- Added option to send an object to the tooltipText object.
- This allows for composite components like pagination to have tooltips for each sub component
* Update: tooltip for pagination component
- Added handling to parse the tooltip for multiple components.
- This allows for composite components like pagination to have tooltips for each sub component
* Update: Type cast for tooltip component
- Made the content passed to tooltip component as a string only
* Update: Fixed tooltip component CSS
* Update: Dropdown option component
- Added a tooltip wrapper to each option
- This is to show on hover text like disabled state
* fix: updated ẇhere clause broken ui for condition
* Add: functions to check and extract expressions
- Loop through the formConfig and find any keys that have a value that is bindable
- Used pre defined regex to check if value is a moustache binding
* Add: Types for evaluated form configs
- Added types for the form configs to be evaluated and their output post eval
* Add: Flow to run the form config
- Run the form config and update the result to the redux state
* Update: Name of the type for formconfigs
- Updated since it was clashing with a component of the same name
* Add: Function to enforce config type checks
- This is done so that the improper configs can be weeded out and the rest of the form can be shown
* Add: Function to update evaluated config
- Added option to update the config if it's values needed evaluation
* Add: Type check for schema sections
* Update: Error handling for invalid control type
- We were throwing an exception till now, changed it to a warning text
* Add: Exposed tooltip for dropdown option disabled state
* Update: switch to json mode functionality
- Added logic to convert data to a string rather than an object when the first switch to JSON mode happens
* Update: Added key to tooltip for dropdown options
* Trigger API modification
* Add: function to fetch default trigger URL
* Update: Made URL optional in dynamic trigger config
* Update: Dynamic trigger API call
- Made the API call for dynamic triggers have URL as optional field
- Added type check to the response of the API call
* Update: resp type for trigger APIs
* Update: Moved code to utils folder
- Moved functions for UQI form eval processing to utils file
* Update: passing original controltype to JS switch
* Update: config for JSON editor mode
- Updated the config to have different options for JSON mode depending on the original control type
* Update: Connected line numbers flag to config
* Revert: CSS changes for tooltip
* Refactor: Removed consle
* Add: type for the config of dynamic values
* Add: Feature to evaluate config for triggers
* Refactor: fix type check errors
* fix: dropdown ui width with text alignment
* Update: fixed selector for dynamic values
* Update: selector call for fetchDynamicValues
* Add table header index prop for columns selector
* migration partial commit
* migration partial commit
* Refactor: removed unused import
* Update: reused function for checking dynamic value
* Update: removed unused import
* Fix format JSON issues
* Retrieve binding paths from entity selector components
* Fixes 6 remaining issues with UQI implementation
* Fix dropdown issues
* Fix dropdown height issues and fixes triggering of APIs when option is deselected
* Migration changes
* Fix QA generated UQI issues
* Fix projection component height and route change logic
* Fix multi select dropdown placeholder text issue and json stringify issue with switching view types
* Reset entity type value when command value changes
* Test changes
* Review comments
* Moved migrations around
* Corrected import statement
* Added JSON schema migration
* Updated schema version
* perf improvements and filter dropdown options feature
* Fix Code mirror component config for toggleComponentToJson input fields.
* Fix prettier issues
* fix prettier issues
* Fix style issues as a result of the merged conflicts
* Fix failing test case
* Fixed a few other flows (#14225)
* Fixed a few other flows
* Review comments
* Fix generate CRUD, fix evaluation of dynamic bindings and fix various styling issues.
* More fixes (#14367)
* Factor in the root formconfig parent key.
* Fix flickering issues, and evaluatedFormConfig issues
* fix: Teeny bugs (#14455)
* Teeny bugs
* Added previous functionality as is
* Improvements in the way we fetch dynamic values
* Fix stringiification issue and cyclic dependency issues
* Resolve projection component values deletion
* Resolve merge conflicts and fix prettier issues
* fix: Tsc issues
* Fix property pane connection navigation
* updating ee locator
* updating inputfield locator
* dropdown locator update
* Merge conflict not properly resolved.
* Fix s3 spec
* Fix Mongo Spec
* Fix some more tests
* fix: prevent cyclic dependency when switching to js mode (#14668)
* add delete events for change from array to string in diff
* add test to assert absence of cyclic dependency error when switching to js in switchgroup widget
* Assert that evaluation is not disabled when no cyclic dependency happens
* Cypress test preparations for google sheets and form controls
* Fixed a few test errors (#14874)
* Add: unit tests for uqi UI updates
- view type tests
- conditional output extraction
- processing conditional output to handle view/enabled state of the component
* Add: completed isValidFormConfig test
* Update: improved tests for update config
- These tests cover the functionality to update a section config after it's components are done evaluating
* Fix failing cypress tests and cyclic dependency issue
* Fixes some more tests
* Fixed migration of row objects (#14896)
* Bumped the version of design system package
* Update: reverted change to EE selector
* Fix deletion pointer
* Update: selector for js on load spec
- Synced with changes related to ADS dropdown
* Fix mongoDBShoppingCart spec
* Remove comments
* Fix: mongo shopping cart test failures
* fix: mongo shopping cart spec
* Dummy push to retrigger vercel
* fix: mongo shopping cart spec
* Update MongoDBShoppingCart_spec.js
* fix: removed unused click away
* dummy commit
* Update: moved helper functions to separate file
* Add: added tests for saga functions
- Worked on testing for
- extractFetchDynamicValueFormConfigs
- extractQueueOfValuesToBeFetched
* Add if check for queueOfValuesToBeFetched
* Resolve review comments
* Empty-Commit
Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Ayush Pahwa <ayush@appsmith.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Albin <albin@appsmith.com>
2022-07-04 05:43:27 +00:00
|
|
|
actionDiffPath?: string,
|
|
|
|
|
hasRouteChanged?: boolean,
|
2023-04-24 04:40:47 +00:00
|
|
|
datasourceConfiguration?: DatasourceConfiguration,
|
2021-08-26 05:37:07 +00:00
|
|
|
) => {
|
|
|
|
|
return {
|
|
|
|
|
type: ReduxActionTypes.RUN_FORM_EVALUATION,
|
feat: Simplified Google Sheets queries (#14869)
* Client changes 1
* add DSL functionality
* Temp commit for refactoring changes
* Do I even know what I'm doing here?
* chore: Second GS layout
* Update: Visibility conditional outputs for schemas
- Added the output from conditional outputs for schema children too
* Update: Entity selector visibility control
- Added logic for controlling visibility of sub components via the JS expressions system
* Update: Passing disabled prop to toggle button
* Update: Passing disabled prop to toggle btn
* Update: Styled component for toggle button
- Added disabled styles based on the disabled prop sent to the toggle form view JSON button
* Update: configProperty role in Entity Selector
- Removed dependance of the configProperty of the entity selector children to it's parent component
* Update: type of placeholder key
- Made placeholder key from form config JSON to accept either string or an object
- Earlier only string was accepted
- This is for pagination component
* Update: Added placeholder control for pagination
* Client changes 1
* add DSL functionality
* Do I even know what I'm doing here?
* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design
* fix: updated tooltip component for wrong ui on entity explore
* temp triggers
* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design (#12395)
* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design
* fix: updated tooltip component for wrong ui on entity explore
* fix: updated tooltip ui, where condition placement, sort by ui
* temp form data access logic
* fix: updated sorting type width ui
* fix: updated ui for spacing, width and text issues
* Update: Type for tooltip of UQI forms
- Added option to send an object to the tooltipText object.
- This allows for composite components like pagination to have tooltips for each sub component
* Update: tooltip for pagination component
- Added handling to parse the tooltip for multiple components.
- This allows for composite components like pagination to have tooltips for each sub component
* Update: Type cast for tooltip component
- Made the content passed to tooltip component as a string only
* Update: Fixed tooltip component CSS
* Update: Dropdown option component
- Added a tooltip wrapper to each option
- This is to show on hover text like disabled state
* fix: updated ẇhere clause broken ui for condition
* Add: functions to check and extract expressions
- Loop through the formConfig and find any keys that have a value that is bindable
- Used pre defined regex to check if value is a moustache binding
* Add: Types for evaluated form configs
- Added types for the form configs to be evaluated and their output post eval
* Add: Flow to run the form config
- Run the form config and update the result to the redux state
* Update: Name of the type for formconfigs
- Updated since it was clashing with a component of the same name
* Add: Function to enforce config type checks
- This is done so that the improper configs can be weeded out and the rest of the form can be shown
* Add: Function to update evaluated config
- Added option to update the config if it's values needed evaluation
* Add: Type check for schema sections
* Update: Error handling for invalid control type
- We were throwing an exception till now, changed it to a warning text
* Add: Exposed tooltip for dropdown option disabled state
* Update: switch to json mode functionality
- Added logic to convert data to a string rather than an object when the first switch to JSON mode happens
* Update: Added key to tooltip for dropdown options
* Trigger API modification
* Add: function to fetch default trigger URL
* Update: Made URL optional in dynamic trigger config
* Update: Dynamic trigger API call
- Made the API call for dynamic triggers have URL as optional field
- Added type check to the response of the API call
* Update: resp type for trigger APIs
* Update: Moved code to utils folder
- Moved functions for UQI form eval processing to utils file
* Update: passing original controltype to JS switch
* Update: config for JSON editor mode
- Updated the config to have different options for JSON mode depending on the original control type
* Update: Connected line numbers flag to config
* Revert: CSS changes for tooltip
* Refactor: Removed consle
* Add: type for the config of dynamic values
* Add: Feature to evaluate config for triggers
* Refactor: fix type check errors
* fix: dropdown ui width with text alignment
* Update: fixed selector for dynamic values
* Update: selector call for fetchDynamicValues
* Add table header index prop for columns selector
* migration partial commit
* migration partial commit
* Refactor: removed unused import
* Update: reused function for checking dynamic value
* Update: removed unused import
* Fix format JSON issues
* Retrieve binding paths from entity selector components
* Fixes 6 remaining issues with UQI implementation
* Fix dropdown issues
* Fix dropdown height issues and fixes triggering of APIs when option is deselected
* Migration changes
* Fix QA generated UQI issues
* Fix projection component height and route change logic
* Fix multi select dropdown placeholder text issue and json stringify issue with switching view types
* Reset entity type value when command value changes
* Test changes
* Review comments
* Moved migrations around
* Corrected import statement
* Added JSON schema migration
* Updated schema version
* perf improvements and filter dropdown options feature
* Fix Code mirror component config for toggleComponentToJson input fields.
* Fix prettier issues
* fix prettier issues
* Fix style issues as a result of the merged conflicts
* Fix failing test case
* Fixed a few other flows (#14225)
* Fixed a few other flows
* Review comments
* Fix generate CRUD, fix evaluation of dynamic bindings and fix various styling issues.
* More fixes (#14367)
* Factor in the root formconfig parent key.
* Fix flickering issues, and evaluatedFormConfig issues
* fix: Teeny bugs (#14455)
* Teeny bugs
* Added previous functionality as is
* Improvements in the way we fetch dynamic values
* Fix stringiification issue and cyclic dependency issues
* Resolve projection component values deletion
* Resolve merge conflicts and fix prettier issues
* fix: Tsc issues
* Fix property pane connection navigation
* updating ee locator
* updating inputfield locator
* dropdown locator update
* Merge conflict not properly resolved.
* Fix s3 spec
* Fix Mongo Spec
* Fix some more tests
* fix: prevent cyclic dependency when switching to js mode (#14668)
* add delete events for change from array to string in diff
* add test to assert absence of cyclic dependency error when switching to js in switchgroup widget
* Assert that evaluation is not disabled when no cyclic dependency happens
* Cypress test preparations for google sheets and form controls
* Fixed a few test errors (#14874)
* Add: unit tests for uqi UI updates
- view type tests
- conditional output extraction
- processing conditional output to handle view/enabled state of the component
* Add: completed isValidFormConfig test
* Update: improved tests for update config
- These tests cover the functionality to update a section config after it's components are done evaluating
* Fix failing cypress tests and cyclic dependency issue
* Fixes some more tests
* Fixed migration of row objects (#14896)
* Bumped the version of design system package
* Update: reverted change to EE selector
* Fix deletion pointer
* Update: selector for js on load spec
- Synced with changes related to ADS dropdown
* Fix mongoDBShoppingCart spec
* Remove comments
* Fix: mongo shopping cart test failures
* fix: mongo shopping cart spec
* Dummy push to retrigger vercel
* fix: mongo shopping cart spec
* Update MongoDBShoppingCart_spec.js
* fix: removed unused click away
* dummy commit
* Update: moved helper functions to separate file
* Add: added tests for saga functions
- Worked on testing for
- extractFetchDynamicValueFormConfigs
- extractQueueOfValuesToBeFetched
* Add if check for queueOfValuesToBeFetched
* Resolve review comments
* Empty-Commit
Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Ayush Pahwa <ayush@appsmith.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Albin <albin@appsmith.com>
2022-07-04 05:43:27 +00:00
|
|
|
payload: {
|
|
|
|
|
formId,
|
|
|
|
|
actionConfiguration: formData,
|
|
|
|
|
datasourceId,
|
|
|
|
|
pluginId,
|
|
|
|
|
actionDiffPath,
|
|
|
|
|
hasRouteChanged,
|
2023-04-24 04:40:47 +00:00
|
|
|
datasourceConfiguration,
|
feat: Simplified Google Sheets queries (#14869)
* Client changes 1
* add DSL functionality
* Temp commit for refactoring changes
* Do I even know what I'm doing here?
* chore: Second GS layout
* Update: Visibility conditional outputs for schemas
- Added the output from conditional outputs for schema children too
* Update: Entity selector visibility control
- Added logic for controlling visibility of sub components via the JS expressions system
* Update: Passing disabled prop to toggle button
* Update: Passing disabled prop to toggle btn
* Update: Styled component for toggle button
- Added disabled styles based on the disabled prop sent to the toggle form view JSON button
* Update: configProperty role in Entity Selector
- Removed dependance of the configProperty of the entity selector children to it's parent component
* Update: type of placeholder key
- Made placeholder key from form config JSON to accept either string or an object
- Earlier only string was accepted
- This is for pagination component
* Update: Added placeholder control for pagination
* Client changes 1
* add DSL functionality
* Do I even know what I'm doing here?
* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design
* fix: updated tooltip component for wrong ui on entity explore
* temp triggers
* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design (#12395)
* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design
* fix: updated tooltip component for wrong ui on entity explore
* fix: updated tooltip ui, where condition placement, sort by ui
* temp form data access logic
* fix: updated sorting type width ui
* fix: updated ui for spacing, width and text issues
* Update: Type for tooltip of UQI forms
- Added option to send an object to the tooltipText object.
- This allows for composite components like pagination to have tooltips for each sub component
* Update: tooltip for pagination component
- Added handling to parse the tooltip for multiple components.
- This allows for composite components like pagination to have tooltips for each sub component
* Update: Type cast for tooltip component
- Made the content passed to tooltip component as a string only
* Update: Fixed tooltip component CSS
* Update: Dropdown option component
- Added a tooltip wrapper to each option
- This is to show on hover text like disabled state
* fix: updated ẇhere clause broken ui for condition
* Add: functions to check and extract expressions
- Loop through the formConfig and find any keys that have a value that is bindable
- Used pre defined regex to check if value is a moustache binding
* Add: Types for evaluated form configs
- Added types for the form configs to be evaluated and their output post eval
* Add: Flow to run the form config
- Run the form config and update the result to the redux state
* Update: Name of the type for formconfigs
- Updated since it was clashing with a component of the same name
* Add: Function to enforce config type checks
- This is done so that the improper configs can be weeded out and the rest of the form can be shown
* Add: Function to update evaluated config
- Added option to update the config if it's values needed evaluation
* Add: Type check for schema sections
* Update: Error handling for invalid control type
- We were throwing an exception till now, changed it to a warning text
* Add: Exposed tooltip for dropdown option disabled state
* Update: switch to json mode functionality
- Added logic to convert data to a string rather than an object when the first switch to JSON mode happens
* Update: Added key to tooltip for dropdown options
* Trigger API modification
* Add: function to fetch default trigger URL
* Update: Made URL optional in dynamic trigger config
* Update: Dynamic trigger API call
- Made the API call for dynamic triggers have URL as optional field
- Added type check to the response of the API call
* Update: resp type for trigger APIs
* Update: Moved code to utils folder
- Moved functions for UQI form eval processing to utils file
* Update: passing original controltype to JS switch
* Update: config for JSON editor mode
- Updated the config to have different options for JSON mode depending on the original control type
* Update: Connected line numbers flag to config
* Revert: CSS changes for tooltip
* Refactor: Removed consle
* Add: type for the config of dynamic values
* Add: Feature to evaluate config for triggers
* Refactor: fix type check errors
* fix: dropdown ui width with text alignment
* Update: fixed selector for dynamic values
* Update: selector call for fetchDynamicValues
* Add table header index prop for columns selector
* migration partial commit
* migration partial commit
* Refactor: removed unused import
* Update: reused function for checking dynamic value
* Update: removed unused import
* Fix format JSON issues
* Retrieve binding paths from entity selector components
* Fixes 6 remaining issues with UQI implementation
* Fix dropdown issues
* Fix dropdown height issues and fixes triggering of APIs when option is deselected
* Migration changes
* Fix QA generated UQI issues
* Fix projection component height and route change logic
* Fix multi select dropdown placeholder text issue and json stringify issue with switching view types
* Reset entity type value when command value changes
* Test changes
* Review comments
* Moved migrations around
* Corrected import statement
* Added JSON schema migration
* Updated schema version
* perf improvements and filter dropdown options feature
* Fix Code mirror component config for toggleComponentToJson input fields.
* Fix prettier issues
* fix prettier issues
* Fix style issues as a result of the merged conflicts
* Fix failing test case
* Fixed a few other flows (#14225)
* Fixed a few other flows
* Review comments
* Fix generate CRUD, fix evaluation of dynamic bindings and fix various styling issues.
* More fixes (#14367)
* Factor in the root formconfig parent key.
* Fix flickering issues, and evaluatedFormConfig issues
* fix: Teeny bugs (#14455)
* Teeny bugs
* Added previous functionality as is
* Improvements in the way we fetch dynamic values
* Fix stringiification issue and cyclic dependency issues
* Resolve projection component values deletion
* Resolve merge conflicts and fix prettier issues
* fix: Tsc issues
* Fix property pane connection navigation
* updating ee locator
* updating inputfield locator
* dropdown locator update
* Merge conflict not properly resolved.
* Fix s3 spec
* Fix Mongo Spec
* Fix some more tests
* fix: prevent cyclic dependency when switching to js mode (#14668)
* add delete events for change from array to string in diff
* add test to assert absence of cyclic dependency error when switching to js in switchgroup widget
* Assert that evaluation is not disabled when no cyclic dependency happens
* Cypress test preparations for google sheets and form controls
* Fixed a few test errors (#14874)
* Add: unit tests for uqi UI updates
- view type tests
- conditional output extraction
- processing conditional output to handle view/enabled state of the component
* Add: completed isValidFormConfig test
* Update: improved tests for update config
- These tests cover the functionality to update a section config after it's components are done evaluating
* Fix failing cypress tests and cyclic dependency issue
* Fixes some more tests
* Fixed migration of row objects (#14896)
* Bumped the version of design system package
* Update: reverted change to EE selector
* Fix deletion pointer
* Update: selector for js on load spec
- Synced with changes related to ADS dropdown
* Fix mongoDBShoppingCart spec
* Remove comments
* Fix: mongo shopping cart test failures
* fix: mongo shopping cart spec
* Dummy push to retrigger vercel
* fix: mongo shopping cart spec
* Update MongoDBShoppingCart_spec.js
* fix: removed unused click away
* dummy commit
* Update: moved helper functions to separate file
* Add: added tests for saga functions
- Worked on testing for
- extractFetchDynamicValueFormConfigs
- extractQueueOfValuesToBeFetched
* Add if check for queueOfValuesToBeFetched
* Resolve review comments
* Empty-Commit
Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Ayush Pahwa <ayush@appsmith.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Albin <albin@appsmith.com>
2022-07-04 05:43:27 +00:00
|
|
|
},
|
2021-08-26 05:37:07 +00:00
|
|
|
};
|
|
|
|
|
};
|
2023-07-05 13:34:03 +00:00
|
|
|
|
|
|
|
|
// These actions require the entire tree to be re-evaluated
|
|
|
|
|
const FORCE_EVAL_ACTIONS = {
|
|
|
|
|
[ReduxActionTypes.INSTALL_LIBRARY_SUCCESS]: true,
|
|
|
|
|
[ReduxActionTypes.UNINSTALL_LIBRARY_SUCCESS]: true,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
export const shouldForceEval = (action: ReduxAction<unknown>) => {
|
|
|
|
|
return !!FORCE_EVAL_ACTIONS[action.type];
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
export const EVAL_AND_LINT_REDUX_ACTIONS = union(
|
|
|
|
|
EVALUATE_REDUX_ACTIONS,
|
|
|
|
|
Object.keys(LINT_REDUX_ACTIONS),
|
|
|
|
|
);
|