PromucFlow_constructor/app/client/packages/rts/src/controllers/BaseController.ts

77 lines
1.7 KiB
TypeScript
Raw Normal View History

import type { Response } from "express";
import type { ValidationError } from "express-validator";
import { StatusCodes } from "http-status-codes";
import type { IdentifierInfo } from "@shared/ast";
interface ErrorData {
error: string | string[];
validationErrors?: ValidationError[];
}
interface ErrorBag {
success: boolean;
message: string;
data?: ErrorData;
}
interface ResponseData {
success: boolean;
message?: string;
data: IdentifierInfo;
}
export default class BaseController {
chore: upgrade typescript to 5.4 (#35181) ## Description Upgrade Typescript from 4.9.5 to 5.4 Upgrading to 5.5 is not possible until we upgrade colors.js lib. It will be done in separate PR More details here https://github.com/color-js/color.js/issues/560#issuecomment-2182819685 ## Automation /ok-to-test tags="@tag.All" ### :mag: Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10163124159> > Commit: 8d2e93f2e2913e715686ccb058d3efddd55aabc9 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10163124159&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 30 Jul 2024 14:11:42 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Updated TypeScript dependency to the latest version (5.4), enhancing overall functionality with potential new features and improvements. - **Improvements** - Enhanced type safety by refining the `isString` function, allowing better type inference and preventing runtime errors. - Improved comments and annotations in the `indirectEval` function for better clarity on its usage and intent. - Corrected typographical errors in error handling logic across multiple controllers, improving reliability in error messaging. - Updated export style for `IconNames` to clarify its purpose as a type, enhancing developer experience. - **Configuration Changes** - Updated Jest configurations to better support ECMAScript Modules (ESM), improving compatibility and allowing for more flexible module handling. - Adjusted TypeScript configuration to enhance module handling and compatibility. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-07-30 14:15:48 +00:00
serverErrorMessage = "Something went wrong";
sendResponse(
response: Response,
fix: Modified on page load actions calculation using AST (#17074) * Changes to on page load logic and consumption for update layout * Slight clean up, tests and stuff * - Added evaluationVersion logic based on application configuration - Added configuration for slim and fat container rts availability - Added backup logic of string comparison for slim containers - Added tests for both paths * Changes to on page load logic and consumption for update layout * Slight clean up, tests and stuff * Cleaned up comments all over * Why isn't there even a setting to disable auto re-formats * update rts logic to use updated shared AST logic * Make changes to naming conventions * Some temp stuff to check if update layout API changes will work out * Added health check endpoint in RTS * Added types for AST request * update: type for save page request object * update: return type for getEditorConfigs func - Added applicationId to the type. - Fetching from the redux store -> applications -> currentApplication -> id * update: url generation func for update page API - added applicationId as query param for the call * Fixed test failures * Fixed merge from release with on page load failure messages * Fixed tests failing after merge * Review comments, more tests, and fix for array index ref directly after .data path * Test fix * Addressed review comments * Updated comment * Fixed rts temporarily, added handling for data as function name, left with tests * fix: failing rts server * Tests for all types of actions and references * Changes to test * Modified type to set * Test fixes * Trying to make a test pass * Added app id in cypress test update dsl * Added app id in cypress test update dsl * Added app id in cypress test update dsl * Removed dep tree temp file * Resolving compile issues after merging from release * updated tests for applicationId * corrected a typo * fixed some more tests * updated test * Updated test * DSL load AppId fix * appId removal * AgHelper LocalStorageCache() * AgHelper LocalStorageCache() - commit 2 * AgHelper LocalStorageCache() - commit 3 * AgHelper LocalStorageCache() - commit 4 * AllWidgets_Reset_spec - Dsl fix * Json_spec fix * S3_2 spec fix * fixes * LocalStorageCache fixes * fixes * fixes * fix * OnLoadActions spec fix * Promises spec fix * S3_2 spec fix * 16702 spec update * OnLoadActions spec trial fix * RTS fix Co-authored-by: Nidhi Nair <cataclysm@Nidhis-MacBook-Pro.local> Co-authored-by: Ayangade Adeoluwa <adeoluayangade@yahoo.com> Co-authored-by: Ayush Pahwa <ayush@appsmith.com> Co-authored-by: Aman Agarwal <aman@appsmith.com> Co-authored-by: Apple <nandan@thinkify.io> Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-11 05:32:44 +00:00
result?: unknown,
message?: string,
code: number = StatusCodes.OK,
): Response<ResponseData> {
return response.status(code).json({
success: true,
message,
data: result,
});
}
sendEntityResponse(
response: Response,
result?: unknown,
success?: boolean,
code: number = StatusCodes.OK,
): Response<ResponseData> {
return response.status(code).json({
success,
data: result,
});
}
sendError(
response: Response,
error: string,
errorMessage,
code: number = StatusCodes.BAD_REQUEST,
): Response<ErrorBag> {
const errorBag: ErrorBag = { success: false, message: error };
if (errorMessage.constructor.name === "Result") {
const validationError = errorMessage.array();
chore: add blank line eslint rule (#36369) ## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### :mag: Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
2024-09-18 16:35:28 +00:00
errorBag.data = {
error: [validationError[0].msg],
validationErrors: validationError,
};
// errorBag.message = validationError[0].msg;
} else {
if (errorMessage.length > 1) {
errorBag.data = { error: errorMessage };
} else {
errorBag.data = { error };
}
}
return response.status(code).json(errorBag);
}
}