2023-07-12 06:42:16 +00:00
|
|
|
// Please follow naming convention : https://www.notion.so/appsmith/Using-Feature-Flags-in-Appsmith-d362fe7acc7d4ef0aa12e1f5f9b83b5f?pvs=4#f6d4242e56284e84af25cadef71b7aeb to create feature flags.
|
2023-06-27 10:45:33 +00:00
|
|
|
export const FEATURE_FLAG = {
|
|
|
|
|
TEST_FLAG: "TEST_FLAG",
|
2023-07-05 06:58:18 +00:00
|
|
|
release_datasource_environments_enabled:
|
|
|
|
|
"release_datasource_environments_enabled",
|
2023-07-21 08:43:36 +00:00
|
|
|
release_appnavigationlogoupload_enabled:
|
|
|
|
|
"release_appnavigationlogoupload_enabled",
|
2023-07-12 13:49:49 +00:00
|
|
|
release_embed_hide_share_settings_enabled:
|
|
|
|
|
"release_embed_hide_share_settings_enabled",
|
2023-10-12 08:24:03 +00:00
|
|
|
release_table_serverside_filtering_enabled:
|
|
|
|
|
"release_table_serverside_filtering_enabled",
|
2023-08-16 10:21:04 +00:00
|
|
|
license_branding_enabled: "license_branding_enabled",
|
2023-08-21 13:42:22 +00:00
|
|
|
license_sso_saml_enabled: "license_sso_saml_enabled",
|
|
|
|
|
license_sso_oidc_enabled: "license_sso_oidc_enabled",
|
2023-10-04 10:10:38 +00:00
|
|
|
license_private_embeds_enabled: "license_private_embeds_enabled",
|
2023-09-25 06:27:23 +00:00
|
|
|
release_show_publish_app_to_community_enabled:
|
|
|
|
|
"release_show_publish_app_to_community_enabled",
|
2023-09-29 20:42:56 +00:00
|
|
|
license_gac_enabled: "license_gac_enabled",
|
2023-10-19 15:20:17 +00:00
|
|
|
release_anvil_enabled: "release_anvil_enabled",
|
2023-11-07 14:55:02 +00:00
|
|
|
license_git_branch_protection_enabled:
|
|
|
|
|
"license_git_branch_protection_enabled",
|
2024-01-24 07:55:58 +00:00
|
|
|
license_git_continuous_delivery_enabled:
|
|
|
|
|
"license_git_continuous_delivery_enabled",
|
2023-11-03 10:48:13 +00:00
|
|
|
license_widget_rtl_support_enabled: "license_widget_rtl_support_enabled",
|
2023-11-27 09:30:20 +00:00
|
|
|
ab_one_click_learning_popover_enabled:
|
|
|
|
|
"ab_one_click_learning_popover_enabled",
|
2024-01-16 14:49:08 +00:00
|
|
|
ab_appsmith_ai_query: "ab_appsmith_ai_query",
|
2024-02-13 11:14:59 +00:00
|
|
|
rollout_remove_feature_walkthrough_enabled:
|
|
|
|
|
"rollout_remove_feature_walkthrough_enabled",
|
2024-11-12 12:05:28 +00:00
|
|
|
rollout_eslint_enabled: "rollout_eslint_enabled",
|
2024-03-08 09:05:02 +00:00
|
|
|
release_drag_drop_building_blocks_enabled:
|
|
|
|
|
"release_drag_drop_building_blocks_enabled",
|
2024-04-11 11:51:14 +00:00
|
|
|
release_layout_conversion_enabled: "release_layout_conversion_enabled",
|
2024-07-05 08:27:59 +00:00
|
|
|
release_anvil_toggle_enabled: "release_anvil_toggle_enabled",
|
2024-10-14 11:04:16 +00:00
|
|
|
release_git_persist_branch_enabled: "release_git_persist_branch_enabled",
|
2024-09-09 10:55:50 +00:00
|
|
|
release_ide_animations_enabled: "release_ide_animations_enabled",
|
2024-10-25 16:22:41 +00:00
|
|
|
release_ide_datasource_selector_enabled:
|
|
|
|
|
"release_ide_datasource_selector_enabled",
|
feat: Update TableWidgetV2 to include customIsLoading property (#36857)
## Description
<ins>Problem</ins>
There are many problems with table loader logic, for which many users
try to implement a modal for loader. These problems stem from dependency
and delay on eval, discussed comprehensively in #12308
<ins>Solution</ins>
This PR updates the TableWidgetV2 component to include a new property
called `customIsLoading`. This property controls the loading state of
the widget and is added to the TableWidgetProps interface. Additionally,
the component's state is updated to include the `customIsLoading`
property.
The `contentConfig` file for the TableWidgetV2 is also modified to
include the `customIsLoading` property with its corresponding label,
control type, help text, and validation.
These changes improve the flexibility and customization options of the
TableWidgetV2 component.
Fixes #12308
_or_
Fixes `Issue URL`
> [!WARNING]
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._
## Automation
/ok-to-test tags="@tag.Table"
### :mag: Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11456273525>
> Commit: 1c6f4f9caabc3aa45ec3916e5ccb465d946ab0a1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11456273525&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Table`
> Spec:
> <hr>Tue, 22 Oct 2024 09:17:37 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Introduced a new feature flag for custom loading states in the table
widget.
- Added properties for managing custom loading behavior in the
`TableWidgetV2`.
- **Bug Fixes**
- Enhanced loading state management to ensure accurate representation
based on new properties.
- **Tests**
- Added unit tests for loading behavior in the `TableWidgetV2`
component, covering default and custom loading scenarios.
- **Documentation**
- Updated help text for properties related to loading states to improve
clarity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-10-22 09:21:45 +00:00
|
|
|
release_table_custom_loading_state_enabled:
|
|
|
|
|
"release_table_custom_loading_state_enabled",
|
2024-11-11 10:29:32 +00:00
|
|
|
release_custom_widget_ai_builder: "release_custom_widget_ai_builder",
|
2024-12-09 11:58:25 +00:00
|
|
|
ab_request_new_integration_enabled: "ab_request_new_integration_enabled",
|
2024-12-13 04:14:19 +00:00
|
|
|
release_evaluation_scope_cache: "release_evaluation_scope_cache",
|
2024-12-11 07:37:30 +00:00
|
|
|
release_table_html_column_type_enabled:
|
|
|
|
|
"release_table_html_column_type_enabled",
|
2024-12-13 08:39:53 +00:00
|
|
|
release_gs_all_sheets_options_enabled:
|
|
|
|
|
"release_gs_all_sheets_options_enabled",
|
2025-01-05 10:21:23 +00:00
|
|
|
release_git_modularisation_enabled: "release_git_modularisation_enabled",
|
2024-12-19 14:30:09 +00:00
|
|
|
ab_premium_datasources_view_enabled: "ab_premium_datasources_view_enabled",
|
2024-12-20 13:32:02 +00:00
|
|
|
kill_session_recordings_enabled: "kill_session_recordings_enabled",
|
|
|
|
|
config_mask_session_recordings_enabled:
|
|
|
|
|
"config_mask_session_recordings_enabled",
|
|
|
|
|
config_user_session_recordings_enabled:
|
|
|
|
|
"config_user_session_recordings_enabled",
|
2025-01-13 08:24:30 +00:00
|
|
|
release_ads_entity_item_enabled: "release_ads_entity_item_enabled",
|
2023-06-27 10:45:33 +00:00
|
|
|
} as const;
|
|
|
|
|
|
|
|
|
|
export type FeatureFlag = keyof typeof FEATURE_FLAG;
|
|
|
|
|
|
|
|
|
|
export type FeatureFlags = Record<FeatureFlag, boolean>;
|
|
|
|
|
|
|
|
|
|
export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = {
|
|
|
|
|
TEST_FLAG: true,
|
2023-07-05 06:58:18 +00:00
|
|
|
release_datasource_environments_enabled: false,
|
2023-07-21 08:43:36 +00:00
|
|
|
release_appnavigationlogoupload_enabled: false,
|
2023-07-12 13:49:49 +00:00
|
|
|
release_embed_hide_share_settings_enabled: false,
|
2023-10-12 08:24:03 +00:00
|
|
|
release_table_serverside_filtering_enabled: false,
|
2023-08-16 10:21:04 +00:00
|
|
|
license_branding_enabled: false,
|
2023-08-21 13:42:22 +00:00
|
|
|
license_sso_saml_enabled: false,
|
|
|
|
|
license_sso_oidc_enabled: false,
|
2023-10-04 10:10:38 +00:00
|
|
|
license_private_embeds_enabled: false,
|
2023-09-25 06:27:23 +00:00
|
|
|
release_show_publish_app_to_community_enabled: false,
|
2023-09-29 20:42:56 +00:00
|
|
|
license_gac_enabled: false,
|
2023-10-19 15:20:17 +00:00
|
|
|
release_anvil_enabled: false,
|
2024-03-08 09:05:02 +00:00
|
|
|
release_drag_drop_building_blocks_enabled: false,
|
2023-11-07 14:55:02 +00:00
|
|
|
license_git_branch_protection_enabled: false,
|
2024-01-24 07:55:58 +00:00
|
|
|
license_git_continuous_delivery_enabled: false,
|
2023-11-03 10:48:13 +00:00
|
|
|
license_widget_rtl_support_enabled: false,
|
2023-11-27 09:30:20 +00:00
|
|
|
ab_one_click_learning_popover_enabled: false,
|
2024-01-16 14:49:08 +00:00
|
|
|
ab_appsmith_ai_query: false,
|
2024-05-13 10:18:11 +00:00
|
|
|
rollout_remove_feature_walkthrough_enabled: true,
|
2024-11-12 12:05:28 +00:00
|
|
|
rollout_eslint_enabled: false,
|
2024-04-11 11:51:14 +00:00
|
|
|
release_layout_conversion_enabled: false,
|
2024-07-05 08:27:59 +00:00
|
|
|
release_anvil_toggle_enabled: false,
|
2024-10-14 11:04:16 +00:00
|
|
|
release_git_persist_branch_enabled: false,
|
2024-09-09 10:55:50 +00:00
|
|
|
release_ide_animations_enabled: false,
|
2024-10-25 16:22:41 +00:00
|
|
|
release_ide_datasource_selector_enabled: false,
|
feat: Update TableWidgetV2 to include customIsLoading property (#36857)
## Description
<ins>Problem</ins>
There are many problems with table loader logic, for which many users
try to implement a modal for loader. These problems stem from dependency
and delay on eval, discussed comprehensively in #12308
<ins>Solution</ins>
This PR updates the TableWidgetV2 component to include a new property
called `customIsLoading`. This property controls the loading state of
the widget and is added to the TableWidgetProps interface. Additionally,
the component's state is updated to include the `customIsLoading`
property.
The `contentConfig` file for the TableWidgetV2 is also modified to
include the `customIsLoading` property with its corresponding label,
control type, help text, and validation.
These changes improve the flexibility and customization options of the
TableWidgetV2 component.
Fixes #12308
_or_
Fixes `Issue URL`
> [!WARNING]
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._
## Automation
/ok-to-test tags="@tag.Table"
### :mag: Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11456273525>
> Commit: 1c6f4f9caabc3aa45ec3916e5ccb465d946ab0a1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11456273525&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Table`
> Spec:
> <hr>Tue, 22 Oct 2024 09:17:37 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Introduced a new feature flag for custom loading states in the table
widget.
- Added properties for managing custom loading behavior in the
`TableWidgetV2`.
- **Bug Fixes**
- Enhanced loading state management to ensure accurate representation
based on new properties.
- **Tests**
- Added unit tests for loading behavior in the `TableWidgetV2`
component, covering default and custom loading scenarios.
- **Documentation**
- Updated help text for properties related to loading states to improve
clarity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-10-22 09:21:45 +00:00
|
|
|
release_table_custom_loading_state_enabled: false,
|
2024-11-11 10:29:32 +00:00
|
|
|
release_custom_widget_ai_builder: false,
|
2024-12-09 11:58:25 +00:00
|
|
|
ab_request_new_integration_enabled: false,
|
2024-12-13 04:14:19 +00:00
|
|
|
release_evaluation_scope_cache: false,
|
2024-12-11 07:37:30 +00:00
|
|
|
release_table_html_column_type_enabled: false,
|
2024-12-13 08:39:53 +00:00
|
|
|
release_gs_all_sheets_options_enabled: false,
|
2025-01-05 10:21:23 +00:00
|
|
|
release_git_modularisation_enabled: false,
|
2024-12-19 14:30:09 +00:00
|
|
|
ab_premium_datasources_view_enabled: false,
|
2024-12-20 13:32:02 +00:00
|
|
|
kill_session_recordings_enabled: false,
|
|
|
|
|
config_user_session_recordings_enabled: true,
|
|
|
|
|
config_mask_session_recordings_enabled: true,
|
2025-01-13 08:24:30 +00:00
|
|
|
release_ads_entity_item_enabled: false,
|
2023-07-12 06:42:16 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
export const AB_TESTING_EVENT_KEYS = {
|
|
|
|
|
abTestingFlagLabel: "abTestingFlagLabel",
|
|
|
|
|
abTestingFlagValue: "abTestingFlagValue",
|
2023-06-27 10:45:33 +00:00
|
|
|
};
|