chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { ExtraDef } from "utils/autocomplete/dataTreeTypeDefCreator";
|
|
|
|
|
import { generateTypeDef } from "utils/autocomplete/dataTreeTypeDefCreator";
|
2023-03-20 11:04:02 +00:00
|
|
|
import type { AppsmithEntity } from "entities/DataTree/dataTreeFactory";
|
2020-06-04 13:49:22 +00:00
|
|
|
import _ from "lodash";
|
2021-12-07 10:19:33 +00:00
|
|
|
import { EVALUATION_PATH } from "utils/DynamicBindingUtils";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { JSCollectionData } from "reducers/entityReducers/jsActionsReducer";
|
|
|
|
|
import type { Def } from "tern";
|
2023-03-20 11:04:02 +00:00
|
|
|
import type { ActionEntity } from "entities/DataTree/types";
|
2020-05-20 11:30:53 +00:00
|
|
|
|
2022-06-21 13:57:34 +00:00
|
|
|
export const entityDefinitions = {
|
2023-03-20 11:04:02 +00:00
|
|
|
APPSMITH: (entity: AppsmithEntity, extraDefsToDefine: ExtraDef) => {
|
2021-12-07 10:19:33 +00:00
|
|
|
const generatedTypeDef = generateTypeDef(
|
|
|
|
|
_.omit(entity, "ENTITY_TYPE", EVALUATION_PATH),
|
2022-08-22 05:47:24 +00:00
|
|
|
extraDefsToDefine,
|
2021-12-07 10:19:33 +00:00
|
|
|
);
|
|
|
|
|
if (
|
|
|
|
|
typeof generatedTypeDef === "object" &&
|
|
|
|
|
typeof generatedTypeDef.geolocation === "object"
|
|
|
|
|
) {
|
|
|
|
|
return {
|
|
|
|
|
...generatedTypeDef,
|
|
|
|
|
geolocation: {
|
|
|
|
|
...generatedTypeDef.geolocation,
|
|
|
|
|
"!doc":
|
|
|
|
|
"The user's geo location information. Only available when requested",
|
|
|
|
|
"!url":
|
|
|
|
|
"https://docs.appsmith.com/v/v1.2.1/framework-reference/geolocation",
|
|
|
|
|
getCurrentPosition:
|
|
|
|
|
"fn(onSuccess: fn() -> void, onError: fn() -> void, options: object) -> void",
|
|
|
|
|
watchPosition: "fn(options: object) -> void",
|
|
|
|
|
clearWatch: "fn() -> void",
|
|
|
|
|
},
|
|
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
return generatedTypeDef;
|
|
|
|
|
},
|
2023-03-20 11:04:02 +00:00
|
|
|
ACTION: (entity: ActionEntity, extraDefsToDefine: ExtraDef) => {
|
2022-08-22 05:47:24 +00:00
|
|
|
const dataDef = generateTypeDef(entity.data, extraDefsToDefine);
|
|
|
|
|
|
|
|
|
|
let data: Def = {
|
2020-06-04 13:49:22 +00:00
|
|
|
"!doc": "The response of the action",
|
|
|
|
|
};
|
2022-08-22 05:47:24 +00:00
|
|
|
|
2020-06-04 13:49:22 +00:00
|
|
|
if (_.isString(dataDef)) {
|
|
|
|
|
data["!type"] = dataDef;
|
|
|
|
|
} else {
|
|
|
|
|
data = { ...data, ...dataDef };
|
|
|
|
|
}
|
|
|
|
|
return {
|
|
|
|
|
"!doc":
|
|
|
|
|
"Actions allow you to connect your widgets to your backend data in a secure manner.",
|
2021-02-03 15:15:16 +00:00
|
|
|
"!url": "https://docs.appsmith.com/v/v1.2.1/framework-reference/run",
|
2020-06-04 13:49:22 +00:00
|
|
|
isLoading: "bool",
|
|
|
|
|
data,
|
2021-07-20 10:02:56 +00:00
|
|
|
responseMeta: {
|
|
|
|
|
"!doc": "The response meta of the action",
|
|
|
|
|
"!type": "?",
|
|
|
|
|
},
|
2022-08-22 05:47:24 +00:00
|
|
|
run: "fn(params: ?) -> +Promise[:t=[!0.<i>.:t]]",
|
2021-12-23 14:17:20 +00:00
|
|
|
clear: "fn() -> +Promise[:t=[!0.<i>.:t]]",
|
2020-06-04 13:49:22 +00:00
|
|
|
};
|
|
|
|
|
},
|
2020-05-20 11:30:53 +00:00
|
|
|
};
|
|
|
|
|
|
2022-10-20 07:09:42 +00:00
|
|
|
/*
|
2022-08-11 09:59:38 +00:00
|
|
|
$__name__$ is just to reduce occurrences of global def showing up in auto completion for user as `$` is less commonly used as entityName/
|
|
|
|
|
|
|
|
|
|
GLOBAL_DEFS are maintained to support definition for array of objects which currently aren't supported by our generateTypeDef.
|
|
|
|
|
*/
|
2020-05-20 11:30:53 +00:00
|
|
|
export const GLOBAL_DEFS = {
|
2022-08-11 09:59:38 +00:00
|
|
|
$__dropdownOption__$: {
|
2020-05-20 11:30:53 +00:00
|
|
|
label: "string",
|
|
|
|
|
value: "string",
|
|
|
|
|
},
|
2023-06-06 08:37:05 +00:00
|
|
|
$__dropdrowOptionWithChildren__$: {
|
|
|
|
|
label: "string",
|
|
|
|
|
value: "string",
|
|
|
|
|
children: "[$__dropdrowOptionWithChildren__$]",
|
|
|
|
|
},
|
2022-08-11 09:59:38 +00:00
|
|
|
$__chartDataPoint__$: {
|
2020-05-20 11:30:53 +00:00
|
|
|
x: "string",
|
|
|
|
|
y: "string",
|
|
|
|
|
},
|
2022-08-11 09:59:38 +00:00
|
|
|
$__file__$: {
|
2021-03-12 08:14:32 +00:00
|
|
|
data: "string",
|
2022-04-21 10:39:24 +00:00
|
|
|
dataFormat: "string",
|
2021-03-12 09:04:05 +00:00
|
|
|
name: "text",
|
|
|
|
|
type: "file",
|
2021-03-12 08:14:32 +00:00
|
|
|
},
|
2022-08-11 09:59:38 +00:00
|
|
|
$__mapMarker__$: {
|
|
|
|
|
lat: "number",
|
|
|
|
|
long: "number",
|
|
|
|
|
title: "string",
|
|
|
|
|
description: "string",
|
2022-01-07 09:57:45 +00:00
|
|
|
},
|
2020-05-20 11:30:53 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
export const GLOBAL_FUNCTIONS = {
|
2021-07-20 10:02:56 +00:00
|
|
|
"!name": "DATA_TREE.APPSMITH.FUNCTIONS",
|
2020-05-20 11:30:53 +00:00
|
|
|
navigateTo: {
|
|
|
|
|
"!doc": "Action to navigate the user to another page or url",
|
2021-12-23 14:17:20 +00:00
|
|
|
"!type":
|
|
|
|
|
"fn(pageNameOrUrl: string, params: {}, target?: string) -> +Promise[:t=[!0.<i>.:t]]",
|
2020-05-20 11:30:53 +00:00
|
|
|
},
|
|
|
|
|
showAlert: {
|
|
|
|
|
"!doc": "Show a temporary notification style message to the user",
|
2021-12-23 14:17:20 +00:00
|
|
|
"!type": "fn(message: string, style: string) -> +Promise[:t=[!0.<i>.:t]]",
|
2020-05-20 11:30:53 +00:00
|
|
|
},
|
|
|
|
|
showModal: {
|
|
|
|
|
"!doc": "Open a modal",
|
2021-12-23 14:17:20 +00:00
|
|
|
"!type": "fn(modalName: string) -> +Promise[:t=[!0.<i>.:t]]",
|
2020-05-20 11:30:53 +00:00
|
|
|
},
|
|
|
|
|
closeModal: {
|
|
|
|
|
"!doc": "Close a modal",
|
2021-12-23 14:17:20 +00:00
|
|
|
"!type": "fn(modalName: string) -> +Promise[:t=[!0.<i>.:t]]",
|
2020-05-20 11:30:53 +00:00
|
|
|
},
|
2020-08-24 12:09:17 +00:00
|
|
|
storeValue: {
|
|
|
|
|
"!doc": "Store key value data locally",
|
2021-12-23 14:17:20 +00:00
|
|
|
"!type": "fn(key: string, value: any) -> +Promise[:t=[!0.<i>.:t]]",
|
2020-08-24 12:09:17 +00:00
|
|
|
},
|
2022-11-01 09:26:13 +00:00
|
|
|
removeValue: {
|
|
|
|
|
"!doc": "Remove key value data locally",
|
|
|
|
|
"!type": "fn(key: string) -> +Promise[:t=[!0.<i>.:t]]",
|
|
|
|
|
},
|
|
|
|
|
clearStore: {
|
|
|
|
|
"!doc": "Clear all key value data locally",
|
|
|
|
|
"!type": "fn() -> +Promise[:t=[!0.<i>.:t]]",
|
|
|
|
|
},
|
2020-08-28 12:07:37 +00:00
|
|
|
download: {
|
|
|
|
|
"!doc": "Download anything as a file",
|
2021-12-23 14:17:20 +00:00
|
|
|
"!type":
|
|
|
|
|
"fn(data: any, fileName: string, fileType?: string) -> +Promise[:t=[!0.<i>.:t]]",
|
2020-08-28 12:07:37 +00:00
|
|
|
},
|
2021-01-07 04:44:30 +00:00
|
|
|
copyToClipboard: {
|
|
|
|
|
"!doc": "Copy text to clipboard",
|
2021-12-23 14:17:20 +00:00
|
|
|
"!type": "fn(data: string, options: object) -> +Promise[:t=[!0.<i>.:t]]",
|
2021-01-07 04:44:30 +00:00
|
|
|
},
|
2021-03-02 12:49:36 +00:00
|
|
|
resetWidget: {
|
|
|
|
|
"!doc": "Reset widget values",
|
2021-12-23 14:17:20 +00:00
|
|
|
"!type":
|
|
|
|
|
"fn(widgetName: string, resetChildren: boolean) -> +Promise[:t=[!0.<i>.:t]]",
|
2021-03-02 12:49:36 +00:00
|
|
|
},
|
2021-10-11 12:55:03 +00:00
|
|
|
setInterval: {
|
|
|
|
|
"!doc": "Execute triggers at a given interval",
|
|
|
|
|
"!type": "fn(callback: fn, interval: number, id?: string) -> void",
|
|
|
|
|
},
|
|
|
|
|
clearInterval: {
|
|
|
|
|
"!doc": "Stop executing a setInterval with id",
|
|
|
|
|
"!type": "fn(id: string) -> void",
|
|
|
|
|
},
|
2022-10-20 07:09:42 +00:00
|
|
|
postWindowMessage: {
|
|
|
|
|
"!doc":
|
|
|
|
|
"Establish cross-origin communication between Window objects/page and iframes",
|
|
|
|
|
"!type": "fn(message: unknown, source: string, targetOrigin: string)",
|
|
|
|
|
},
|
2020-05-20 11:30:53 +00:00
|
|
|
};
|
2021-09-08 17:32:22 +00:00
|
|
|
|
2022-04-07 20:37:03 +00:00
|
|
|
export const getPropsForJSActionEntity = ({
|
|
|
|
|
config,
|
|
|
|
|
data,
|
|
|
|
|
}: JSCollectionData): Record<string, string> => {
|
|
|
|
|
const properties: Record<string, any> = {};
|
|
|
|
|
const actions = config.actions;
|
2021-09-08 17:32:22 +00:00
|
|
|
if (actions && actions.length > 0)
|
2022-04-07 20:37:03 +00:00
|
|
|
for (let i = 0; i < config.actions.length; i++) {
|
|
|
|
|
const action = config.actions[i];
|
2021-09-08 17:32:22 +00:00
|
|
|
properties[action.name + "()"] = "Function";
|
2022-04-07 20:37:03 +00:00
|
|
|
if (data && action.id in data) {
|
|
|
|
|
properties[action.name + ".data"] = data[action.id];
|
|
|
|
|
}
|
2021-09-08 17:32:22 +00:00
|
|
|
}
|
2022-04-07 20:37:03 +00:00
|
|
|
const variablesProps = config.variables;
|
2021-09-08 17:32:22 +00:00
|
|
|
if (variablesProps && variablesProps.length > 0) {
|
|
|
|
|
for (let i = 0; i < variablesProps.length; i++) {
|
|
|
|
|
const variableProp = variablesProps[i];
|
|
|
|
|
properties[variableProp.name] = variableProp.value;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return properties;
|
|
|
|
|
};
|
2022-06-21 13:57:34 +00:00
|
|
|
|
|
|
|
|
export type EntityDefinitionsOptions = keyof typeof entityDefinitions;
|