2020-04-28 06:52:53 +00:00
|
|
|
import styled from "styled-components";
|
|
|
|
|
import { Select, MultiSelect } from "@blueprintjs/select";
|
|
|
|
|
import {
|
|
|
|
|
Switch,
|
|
|
|
|
InputGroup,
|
|
|
|
|
Button,
|
|
|
|
|
Classes,
|
|
|
|
|
Popover,
|
|
|
|
|
MenuItem,
|
|
|
|
|
} from "@blueprintjs/core";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { DropdownOption } from "components/constants";
|
|
|
|
|
import type { ContainerOrientation } from "constants/WidgetConstants";
|
2020-04-28 06:52:53 +00:00
|
|
|
import { DateInput } from "@blueprintjs/datetime";
|
|
|
|
|
import { Colors } from "constants/Colors";
|
|
|
|
|
|
|
|
|
|
type ControlWrapperProps = {
|
|
|
|
|
orientation?: ContainerOrientation;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
export const ControlWrapper = styled.div<ControlWrapperProps>`
|
2020-12-24 04:32:25 +00:00
|
|
|
display: ${(props) =>
|
|
|
|
|
props.orientation === "HORIZONTAL" ? "flex" : "block"};
|
2020-04-28 06:52:53 +00:00
|
|
|
justify-content: space-between;
|
|
|
|
|
align-items: center;
|
2020-12-24 04:32:25 +00:00
|
|
|
flex-direction: ${(props) =>
|
2022-06-30 11:29:09 +00:00
|
|
|
props.orientation === "VERTICAL" ? "column" : "row"};
|
2020-12-24 04:32:25 +00:00
|
|
|
margin: ${(props) => props.theme.spaces[3]}px 0;
|
2020-04-28 06:52:53 +00:00
|
|
|
& > label {
|
2020-12-24 04:32:25 +00:00
|
|
|
color: ${(props) => props.theme.colors.paneText};
|
|
|
|
|
margin-bottom: ${(props) => props.theme.spaces[1]}px;
|
|
|
|
|
font-size: ${(props) => props.theme.fontSizes[3]}px;
|
2020-04-28 06:52:53 +00:00
|
|
|
}
|
|
|
|
|
&&& > label:first-of-type {
|
|
|
|
|
display: block;
|
|
|
|
|
}
|
|
|
|
|
&&& > label {
|
|
|
|
|
display: inline-block;
|
|
|
|
|
}
|
|
|
|
|
`;
|
|
|
|
|
|
|
|
|
|
export const ControlPropertyLabelContainer = styled.div`
|
|
|
|
|
display: flex;
|
|
|
|
|
align-items: center;
|
|
|
|
|
label {
|
2020-12-24 04:32:25 +00:00
|
|
|
color: ${(props) => props.theme.colors.paneText};
|
|
|
|
|
margin-bottom: ${(props) => props.theme.spaces[1]}px;
|
|
|
|
|
font-size: ${(props) => props.theme.fontSizes[3]}px;
|
2020-04-28 06:52:53 +00:00
|
|
|
}
|
|
|
|
|
.underline {
|
2020-12-24 04:32:25 +00:00
|
|
|
color: ${(props) => props.theme.colors.paneTextUnderline};
|
2020-04-28 06:52:53 +00:00
|
|
|
}
|
|
|
|
|
`;
|
|
|
|
|
|
|
|
|
|
export const JSToggleButton = styled.span<{ active: boolean }>`
|
|
|
|
|
margin: 0 3px;
|
|
|
|
|
cursor: pointer;
|
|
|
|
|
height: 24px;
|
|
|
|
|
svg {
|
|
|
|
|
height: 24px;
|
|
|
|
|
rect {
|
2020-12-24 04:32:25 +00:00
|
|
|
fill: ${(props) =>
|
2020-04-28 06:52:53 +00:00
|
|
|
props.active
|
2020-08-10 04:54:33 +00:00
|
|
|
? props.theme.colors.primaryOld
|
2020-04-28 06:52:53 +00:00
|
|
|
: props.theme.colors.paneIcon};
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
`;
|
|
|
|
|
|
|
|
|
|
export const StyledDropDownContainer = styled.div`
|
|
|
|
|
&&&& .${Classes.BUTTON} {
|
|
|
|
|
box-shadow: none;
|
|
|
|
|
border-radius: 4px;
|
|
|
|
|
background-color: ${Colors.SHARK};
|
|
|
|
|
color: ${Colors.CADET_BLUE};
|
|
|
|
|
background-image: none;
|
|
|
|
|
}
|
|
|
|
|
&&&& .${Classes.MENU_ITEM} {
|
2020-12-24 04:32:25 +00:00
|
|
|
border-radius: ${(props) => props.theme.radii[1]}px;
|
2020-04-28 06:52:53 +00:00
|
|
|
&:hover {
|
|
|
|
|
background: ${Colors.POLAR};
|
|
|
|
|
}
|
|
|
|
|
&.${Classes.ACTIVE} {
|
|
|
|
|
background: ${Colors.POLAR};
|
2020-12-24 04:32:25 +00:00
|
|
|
color: ${(props) => props.theme.colors.textDefault};
|
2020-04-28 06:52:53 +00:00
|
|
|
position: relative;
|
|
|
|
|
&.single-select {
|
|
|
|
|
&:before {
|
|
|
|
|
left: 0;
|
|
|
|
|
top: -2px;
|
|
|
|
|
position: absolute;
|
|
|
|
|
content: "";
|
2020-12-24 04:32:25 +00:00
|
|
|
background: ${(props) => props.theme.colors.primaryOld};
|
2020-04-28 06:52:53 +00:00
|
|
|
border-radius: 4px 0 0 4px;
|
|
|
|
|
width: 4px;
|
|
|
|
|
height: 100%;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
&& .${Classes.POPOVER} {
|
|
|
|
|
width: 100%;
|
2020-12-24 04:32:25 +00:00
|
|
|
border-radius: ${(props) => props.theme.radii[1]}px;
|
2020-04-28 06:52:53 +00:00
|
|
|
box-shadow: 0px 2px 4px rgba(67, 70, 74, 0.14);
|
2020-12-24 04:32:25 +00:00
|
|
|
padding: ${(props) => props.theme.spaces[3]}px;
|
2020-04-28 06:52:53 +00:00
|
|
|
background: white;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
&&&& .${Classes.POPOVER_CONTENT} {
|
|
|
|
|
box-shadow: none;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
&& .${Classes.POPOVER_WRAPPER} {
|
|
|
|
|
.${Classes.OVERLAY} {
|
|
|
|
|
.${Classes.TRANSITION_CONTAINER} {
|
|
|
|
|
width: 100%;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
&& .${Classes.MENU} {
|
|
|
|
|
max-width: 100%;
|
|
|
|
|
max-height: auto;
|
|
|
|
|
}
|
|
|
|
|
width: 100%;
|
|
|
|
|
`;
|
|
|
|
|
const DropDown = Select.ofType<DropdownOption>();
|
|
|
|
|
export const StyledDropDown = styled(DropDown)`
|
|
|
|
|
div {
|
|
|
|
|
flex: 1 1 auto;
|
|
|
|
|
}
|
|
|
|
|
span {
|
|
|
|
|
width: 100%;
|
|
|
|
|
position: relative;
|
|
|
|
|
}
|
|
|
|
|
.${Classes.BUTTON} {
|
|
|
|
|
display: flex;
|
|
|
|
|
width: 100%;
|
|
|
|
|
align-items: center;
|
|
|
|
|
justify-content: space-between;
|
|
|
|
|
}
|
|
|
|
|
.${Classes.BUTTON_TEXT} {
|
|
|
|
|
text-overflow: ellipsis;
|
|
|
|
|
text-align: left;
|
|
|
|
|
overflow: hidden;
|
|
|
|
|
display: -webkit-box;
|
|
|
|
|
-webkit-line-clamp: 1;
|
|
|
|
|
-webkit-box-orient: vertical;
|
|
|
|
|
}
|
|
|
|
|
&& {
|
|
|
|
|
.${Classes.ICON} {
|
|
|
|
|
width: fit-content;
|
|
|
|
|
color: ${Colors.SLATE_GRAY};
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
`;
|
|
|
|
|
|
|
|
|
|
export const StyledPopover = styled(Popover)`
|
|
|
|
|
div {
|
|
|
|
|
flex: 1 1 auto;
|
|
|
|
|
}
|
|
|
|
|
span {
|
|
|
|
|
width: 100%;
|
|
|
|
|
position: relative;
|
|
|
|
|
}
|
|
|
|
|
.${Classes.BUTTON} {
|
|
|
|
|
display: flex;
|
|
|
|
|
width: 100%;
|
|
|
|
|
align-items: center;
|
|
|
|
|
justify-content: space-between;
|
|
|
|
|
}
|
|
|
|
|
.${Classes.BUTTON_TEXT} {
|
|
|
|
|
text-overflow: ellipsis;
|
|
|
|
|
text-align: left;
|
|
|
|
|
overflow: hidden;
|
|
|
|
|
display: -webkit-box;
|
|
|
|
|
-webkit-line-clamp: 1;
|
|
|
|
|
-webkit-box-orient: vertical;
|
|
|
|
|
}
|
|
|
|
|
&& {
|
|
|
|
|
.${Classes.ICON} {
|
|
|
|
|
width: fit-content;
|
|
|
|
|
color: ${Colors.SLATE_GRAY};
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
`;
|
|
|
|
|
|
|
|
|
|
export const StyledMenuItem = styled(MenuItem)`
|
|
|
|
|
&&&&&& {
|
2020-12-24 04:32:25 +00:00
|
|
|
border-radius: ${(props) => props.theme.radii[1]}px;
|
2020-04-28 06:52:53 +00:00
|
|
|
&:hover {
|
|
|
|
|
background: ${Colors.POLAR};
|
|
|
|
|
}
|
|
|
|
|
&.${Classes.ACTIVE} {
|
|
|
|
|
background: ${Colors.POLAR};
|
2020-12-24 04:32:25 +00:00
|
|
|
color: ${(props) => props.theme.colors.textDefault};
|
2020-04-28 06:52:53 +00:00
|
|
|
position: relative;
|
|
|
|
|
&.single-select {
|
|
|
|
|
&:before {
|
|
|
|
|
left: 0;
|
|
|
|
|
top: -2px;
|
|
|
|
|
position: absolute;
|
|
|
|
|
content: "";
|
2020-12-24 04:32:25 +00:00
|
|
|
background: ${(props) => props.theme.colors.primaryOld};
|
2020-04-28 06:52:53 +00:00
|
|
|
border-radius: 4px 0 0 4px;
|
|
|
|
|
width: 4px;
|
|
|
|
|
height: 100%;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
`;
|
|
|
|
|
|
|
|
|
|
const MultiSelectDropDown = MultiSelect.ofType<DropdownOption>();
|
|
|
|
|
export const StyledMultiSelectDropDown = styled(MultiSelectDropDown)`
|
|
|
|
|
&&& button {
|
2020-12-24 04:32:25 +00:00
|
|
|
background: ${(props) => props.theme.colors.paneInputBG};
|
|
|
|
|
color: ${(props) => props.theme.colors.textOnDarkBG};
|
2020-04-28 06:52:53 +00:00
|
|
|
box-shadow: none;
|
|
|
|
|
}
|
|
|
|
|
`;
|
|
|
|
|
|
|
|
|
|
export const StyledSwitch = styled(Switch)`
|
|
|
|
|
margin-left: 10px;
|
2021-10-04 15:34:37 +00:00
|
|
|
&&&&& input {
|
|
|
|
|
~ span {
|
|
|
|
|
background: ${Colors.GREY_5};
|
|
|
|
|
width: 40px;
|
|
|
|
|
}
|
|
|
|
|
~ span:hover {
|
|
|
|
|
background: ${Colors.DARK_GRAY};
|
|
|
|
|
}
|
|
|
|
|
&:checked ~ span {
|
|
|
|
|
background: ${Colors.PRIMARY_ORANGE};
|
|
|
|
|
}
|
|
|
|
|
&:checked ~ span:hover {
|
|
|
|
|
background: #bf4109;
|
|
|
|
|
}
|
2020-04-28 06:52:53 +00:00
|
|
|
}
|
|
|
|
|
`;
|
|
|
|
|
|
|
|
|
|
export const StyledDynamicInput = styled.div`
|
|
|
|
|
&&& {
|
|
|
|
|
input {
|
|
|
|
|
border: none;
|
2020-12-24 04:32:25 +00:00
|
|
|
color: ${(props) => props.theme.colors.textOnDarkBG};
|
|
|
|
|
background: ${(props) => props.theme.colors.paneInputBG};
|
2020-04-28 06:52:53 +00:00
|
|
|
&:focus {
|
|
|
|
|
border: none;
|
2020-12-24 04:32:25 +00:00
|
|
|
color: ${(props) => props.theme.colors.textOnDarkBG};
|
|
|
|
|
background: ${(props) => props.theme.colors.paneInputBG};
|
2020-04-28 06:52:53 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
`;
|
|
|
|
|
|
|
|
|
|
export const StyledInputGroup = styled(InputGroup)`
|
|
|
|
|
& > input {
|
2020-12-24 04:32:25 +00:00
|
|
|
color: ${(props) => props.theme.colors.textOnDarkBG};
|
|
|
|
|
background: ${(props) => props.theme.colors.paneInputBG};
|
2020-04-28 06:52:53 +00:00
|
|
|
}
|
|
|
|
|
`;
|
|
|
|
|
|
|
|
|
|
export const StyledDatePicker = styled(DateInput)`
|
|
|
|
|
& {
|
|
|
|
|
input {
|
2020-12-24 04:32:25 +00:00
|
|
|
color: ${(props) => props.theme.colors.textOnDarkBG};
|
|
|
|
|
background: ${(props) => props.theme.colors.paneInputBG};
|
2020-04-28 06:52:53 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
`;
|
|
|
|
|
|
|
|
|
|
export const StyledPropertyPaneButton = styled(Button)`
|
|
|
|
|
&&&& {
|
2020-12-24 04:32:25 +00:00
|
|
|
background-color: ${(props) => props.theme.colors.infoOld};
|
2020-04-28 06:52:53 +00:00
|
|
|
color: #ffffff;
|
|
|
|
|
.bp3-icon {
|
|
|
|
|
color: #ffffff;
|
|
|
|
|
margin-right: 4px;
|
|
|
|
|
}
|
|
|
|
|
svg {
|
|
|
|
|
width: 14px;
|
|
|
|
|
height: 14px;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
`;
|