chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { FlattenedWidgetProps } from "reducers/entityReducers/canvasWidgetsReducer";
|
2021-04-21 14:34:25 +00:00
|
|
|
import { generateDataTreeWidget } from "entities/DataTree/dataTreeWidget";
|
2021-04-26 05:41:32 +00:00
|
|
|
import {
|
|
|
|
|
ENTITY_TYPE,
|
|
|
|
|
EvaluationSubstitutionType,
|
|
|
|
|
} from "entities/DataTree/dataTreeFactory";
|
2021-04-21 14:34:25 +00:00
|
|
|
import WidgetFactory from "utils/WidgetFactory";
|
2021-09-09 15:10:22 +00:00
|
|
|
|
2021-07-26 05:50:46 +00:00
|
|
|
import { ValidationTypes } from "constants/WidgetValidation";
|
2022-12-02 12:45:11 +00:00
|
|
|
import { RenderModes } from "constants/WidgetConstants";
|
2021-04-21 14:34:25 +00:00
|
|
|
|
2021-09-09 15:10:22 +00:00
|
|
|
// const WidgetTypes = WidgetFactory.widgetTypes;
|
|
|
|
|
|
2021-04-21 14:34:25 +00:00
|
|
|
describe("generateDataTreeWidget", () => {
|
|
|
|
|
beforeEach(() => {
|
|
|
|
|
const getMetaProps = jest.spyOn(
|
|
|
|
|
WidgetFactory,
|
|
|
|
|
"getWidgetMetaPropertiesMap",
|
|
|
|
|
);
|
|
|
|
|
getMetaProps.mockReturnValueOnce({
|
|
|
|
|
text: undefined,
|
|
|
|
|
isDirty: false,
|
|
|
|
|
isFocused: false,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const getDerivedProps = jest.spyOn(
|
|
|
|
|
WidgetFactory,
|
|
|
|
|
"getWidgetDerivedPropertiesMap",
|
|
|
|
|
);
|
|
|
|
|
getDerivedProps.mockReturnValueOnce({
|
|
|
|
|
isValid: "{{true}}",
|
|
|
|
|
value: "{{this.text}}",
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const getDefaultProps = jest.spyOn(
|
|
|
|
|
WidgetFactory,
|
|
|
|
|
"getWidgetDefaultPropertiesMap",
|
|
|
|
|
);
|
|
|
|
|
getDefaultProps.mockReturnValueOnce({
|
|
|
|
|
text: "defaultText",
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const getPropertyConfig = jest.spyOn(
|
|
|
|
|
WidgetFactory,
|
|
|
|
|
"getWidgetPropertyPaneConfig",
|
|
|
|
|
);
|
|
|
|
|
getPropertyConfig.mockReturnValueOnce([
|
|
|
|
|
{
|
|
|
|
|
sectionName: "General",
|
|
|
|
|
children: [
|
|
|
|
|
{
|
|
|
|
|
propertyName: "inputType",
|
2023-05-19 18:37:06 +00:00
|
|
|
label: "Data type",
|
2021-04-21 14:34:25 +00:00
|
|
|
controlType: "DROP_DOWN",
|
|
|
|
|
isBindProperty: false,
|
|
|
|
|
isTriggerProperty: false,
|
|
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
propertyName: "defaultText",
|
|
|
|
|
label: "Default Text",
|
|
|
|
|
controlType: "INPUT_TEXT",
|
|
|
|
|
isBindProperty: true,
|
|
|
|
|
isTriggerProperty: false,
|
2021-07-26 05:50:46 +00:00
|
|
|
validation: { type: ValidationTypes.TEXT },
|
2021-04-21 14:34:25 +00:00
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
propertyName: "placeholderText",
|
|
|
|
|
label: "Placeholder",
|
|
|
|
|
controlType: "INPUT_TEXT",
|
|
|
|
|
isBindProperty: true,
|
|
|
|
|
isTriggerProperty: false,
|
2021-07-26 05:50:46 +00:00
|
|
|
validation: { type: ValidationTypes.TEXT },
|
2021-04-21 14:34:25 +00:00
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
propertyName: "regex",
|
|
|
|
|
label: "Regex",
|
|
|
|
|
controlType: "INPUT_TEXT",
|
|
|
|
|
isBindProperty: true,
|
|
|
|
|
isTriggerProperty: false,
|
2021-07-26 05:50:46 +00:00
|
|
|
validation: { type: ValidationTypes.REGEX },
|
2021-04-21 14:34:25 +00:00
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
propertyName: "errorMessage",
|
2023-05-19 18:37:06 +00:00
|
|
|
label: "Error message",
|
2021-04-21 14:34:25 +00:00
|
|
|
controlType: "INPUT_TEXT",
|
|
|
|
|
isBindProperty: true,
|
|
|
|
|
isTriggerProperty: false,
|
2021-07-26 05:50:46 +00:00
|
|
|
validation: { type: ValidationTypes.TEXT },
|
2021-04-21 14:34:25 +00:00
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
propertyName: "isRequired",
|
|
|
|
|
label: "Required",
|
|
|
|
|
controlType: "SWITCH",
|
|
|
|
|
isJSConvertible: true,
|
|
|
|
|
isBindProperty: true,
|
|
|
|
|
isTriggerProperty: false,
|
2021-07-26 05:50:46 +00:00
|
|
|
validation: { type: ValidationTypes.BOOLEAN },
|
2021-04-21 14:34:25 +00:00
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
propertyName: "isVisible",
|
|
|
|
|
label: "Visible",
|
|
|
|
|
controlType: "SWITCH",
|
|
|
|
|
isJSConvertible: true,
|
|
|
|
|
isBindProperty: true,
|
|
|
|
|
isTriggerProperty: false,
|
2021-07-26 05:50:46 +00:00
|
|
|
validation: { type: ValidationTypes.BOOLEAN },
|
2021-04-21 14:34:25 +00:00
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
propertyName: "isDisabled",
|
|
|
|
|
label: "Disabled",
|
|
|
|
|
controlType: "SWITCH",
|
|
|
|
|
isJSConvertible: true,
|
|
|
|
|
isBindProperty: true,
|
|
|
|
|
isTriggerProperty: false,
|
2021-07-26 05:50:46 +00:00
|
|
|
validation: { type: ValidationTypes.BOOLEAN },
|
2021-04-21 14:34:25 +00:00
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
propertyName: "resetOnSubmit",
|
|
|
|
|
label: "Reset on submit",
|
|
|
|
|
controlType: "SWITCH",
|
|
|
|
|
isJSConvertible: true,
|
|
|
|
|
isBindProperty: true,
|
|
|
|
|
isTriggerProperty: false,
|
2021-07-26 05:50:46 +00:00
|
|
|
validation: { type: ValidationTypes.BOOLEAN },
|
2021-04-21 14:34:25 +00:00
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
},
|
|
|
|
|
{
|
2021-11-26 09:32:04 +00:00
|
|
|
sectionName: "Events",
|
2021-04-21 14:34:25 +00:00
|
|
|
children: [
|
|
|
|
|
{
|
|
|
|
|
propertyName: "onTextChanged",
|
|
|
|
|
label: "onTextChanged",
|
|
|
|
|
controlType: "ACTION_SELECTOR",
|
|
|
|
|
isJSConvertible: true,
|
|
|
|
|
isBindProperty: true,
|
|
|
|
|
isTriggerProperty: true,
|
|
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
propertyName: "onSubmit",
|
|
|
|
|
label: "onSubmit",
|
|
|
|
|
controlType: "ACTION_SELECTOR",
|
|
|
|
|
isJSConvertible: true,
|
|
|
|
|
isBindProperty: true,
|
|
|
|
|
isTriggerProperty: true,
|
|
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
},
|
|
|
|
|
]);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
afterEach(() => {
|
|
|
|
|
jest.clearAllMocks();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("generates enhanced widget with the right properties", () => {
|
|
|
|
|
const widget: FlattenedWidgetProps = {
|
|
|
|
|
bottomRow: 0,
|
|
|
|
|
isLoading: false,
|
|
|
|
|
leftColumn: 0,
|
|
|
|
|
parentColumnSpace: 0,
|
|
|
|
|
parentRowSpace: 0,
|
|
|
|
|
renderMode: RenderModes.CANVAS,
|
|
|
|
|
rightColumn: 0,
|
|
|
|
|
topRow: 0,
|
2022-01-18 07:52:24 +00:00
|
|
|
type: "INPUT_WIDGET_V2",
|
2021-04-21 14:34:25 +00:00
|
|
|
version: 0,
|
|
|
|
|
widgetId: "123",
|
|
|
|
|
widgetName: "Input1",
|
2022-01-28 11:10:05 +00:00
|
|
|
defaultText: "",
|
feat: JSON Form widget (#8472)
* initial layout
* updated parser to support nested array
* array field rendering
* changes
* ts fix
* minor revert FormWidget
* modified schema structure
* select and switch fields
* added checkbox field
* added RadioGroupField
* partial DateField and defaults, typing refactoring
* added label and field type change
* minor ts changes
* changes
* modified widget/utils for nested panelConfig, modified schema to object approach
* array/object label support
* hide field configuration when children not present
* added tooltip
* field visibility option
* disabled state
* upgraded tslib, form initial values
* custom field configuration - add/hide/edit
* field configuration - label change
* return input when field configuration reaches max depth
* minor changes
* form - scroll, fixedfooter, enitity defn and other minior changes
* form title
* unregister on unmount
* fixes
* zero state
* fix field padding
* patched updating form values, removed linting warnings
* configured action buttons
* minor fix
* minor change
* property pane - sort fields in field configuration
* refactor include all properties
* checkbox properties
* date properties
* refactor typings and radio group properties
* switch, multselect, select, array, object properties
* minor changes
* default value
* ts fixes
* checkbox field properties implementation
* date field prop implementation
* switch field
* select field and fix deep nested meta properties
* multiselect implementation
* minor change
* input field implementation
* fix position jump on field type change
* initial accordian
* field state property and auto-complete of JSONFormComputeControl
* merge fixes
* renamed FormBuilder to JSONForm
* source data validation minor change
* custom field default value fix
* Editable keys for custom field
* minor fixes
* replaced useFieldArray with custom logic, added widget icon
* array and object accordian with border/background styling
* minor change
* disabled states for array and objects
* default value minor fix
* form level styles
* modified logic for isDisabled for array and object, added disabledWhenInvalid, exposed isValid to fieldState for text input, removed useDisableChildren
* added isValid for all field types
* fixed reset to default values
* debounce form values update
* minor change
* minor change
* fix crash - source data change multi-select to array, fix crash - change of options
* fix positioning
* detect date type in source data
* fix crash - when object is passed to regex input field
* fixed default sourceData path for fields
* accodion keep children mounted on collapse
* jest test for schemaParser
* widget/helper and useRegisterFieldInvalid test
* tests for property config helper and generatePanelPropertyConfig
* fix input field validation not appearing
* fix date field type detection
* rename data -> formData
* handle null/undefined field value change in sourceData
* added null/undefined as valid values for defaultValue text field
* auto detect email field
* set formData default value on initial load
* switch field inline positioning
* field margin fix for row direction
* select full width
* fiex date field default value - out of range
* fix any field type to array
* array default value logic change
* base cypress test changes
* initial json form render cy test
* key sanitization
* fix fieldState update logic
* required design, object/array background color, accordion changes, fix - add new custom field
* minor change
* cypress tests
* fix date formatted value, field state cypress test
* cypress - field properties test and fixes
* rename test file
* fix accessort change to blank value, cypress tests
* fix array field default value for modified accessor
* minor fix
* added animate loading
* fix empty state, add new custom field
* test data fix
* fix warnings
* fix timePrecision visibility
* button styling
* ported input v2
* fix jest tests
* fix cypress tests
* perf changes
* perf improvement
* added comments
* multiselect changes
* input field perf refactor
* array field, object field refactor performance
* checkbox field refactor
* refectored date, radio, select and switch
* fixes
* test fixes
* fixes
* minor fix
* rename field renderer
* remove tracked fieldRenderer field
* cypress test fixes
* cypress changes
* array default value fixes
* arrayfield passedDefaultValue
* auto enabled JS mode for few properties, reverted swith and date property controls
* cypress changes
* added widget sniping mode and fixed object passedDefaultValue
* multiselect v2
* select v2
* fix jest tests
* test fixes
* field limit
* rename field type dropdown texts
* field type changes fixes
* jest fixes
* loading state submit button
* default source data for new widget
* modify limit message
* multiseelct default value changes and cypress fix
* select default value
* keep default value intact on field type change
* TextTable cypress text fix
* review changes
* fixed footer changes
* collapse styles section by default
* fixed footer changes
* form modes
* custom field key rentention
* fixed footer fix in view mode
* non ascii characters
* fix meta merge in dataTreeWidget
* minor fixes
* rename useRegisterFieldInvalid.ts -> useRegisterFieldValidity.ts
* modified dependency injection into evaluated values
* refactored fixedfooter logic
* minor change
* accessor update
* minor change
* fixes
* QA fixes date field, scroll content
* fix phone number field, removed visiblity option from array item
* fix sourceData autocomplete
* reset logic
* fix multiselect reset
* form values hydration on widget drag
* code review changes
* reverted order of merge dataTreeWidget
* fixes
* added button titles, fixed hydration issue
* default value fixes
* upgraded react hook form, modified array-level/field-level default value logic
* fixed select validation
* added icon entity explorer, modified icon align control
* modify accessor validation for mongo db _id
* update email field regex
* review changes
* explicitly handle empty source data validation
2022-03-24 07:13:25 +00:00
|
|
|
deepObj: {
|
|
|
|
|
level1: {
|
|
|
|
|
value: 10,
|
|
|
|
|
},
|
|
|
|
|
},
|
2021-04-21 14:34:25 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const widgetMetaProps: Record<string, unknown> = {
|
|
|
|
|
text: "Tester",
|
|
|
|
|
isDirty: true,
|
feat: JSON Form widget (#8472)
* initial layout
* updated parser to support nested array
* array field rendering
* changes
* ts fix
* minor revert FormWidget
* modified schema structure
* select and switch fields
* added checkbox field
* added RadioGroupField
* partial DateField and defaults, typing refactoring
* added label and field type change
* minor ts changes
* changes
* modified widget/utils for nested panelConfig, modified schema to object approach
* array/object label support
* hide field configuration when children not present
* added tooltip
* field visibility option
* disabled state
* upgraded tslib, form initial values
* custom field configuration - add/hide/edit
* field configuration - label change
* return input when field configuration reaches max depth
* minor changes
* form - scroll, fixedfooter, enitity defn and other minior changes
* form title
* unregister on unmount
* fixes
* zero state
* fix field padding
* patched updating form values, removed linting warnings
* configured action buttons
* minor fix
* minor change
* property pane - sort fields in field configuration
* refactor include all properties
* checkbox properties
* date properties
* refactor typings and radio group properties
* switch, multselect, select, array, object properties
* minor changes
* default value
* ts fixes
* checkbox field properties implementation
* date field prop implementation
* switch field
* select field and fix deep nested meta properties
* multiselect implementation
* minor change
* input field implementation
* fix position jump on field type change
* initial accordian
* field state property and auto-complete of JSONFormComputeControl
* merge fixes
* renamed FormBuilder to JSONForm
* source data validation minor change
* custom field default value fix
* Editable keys for custom field
* minor fixes
* replaced useFieldArray with custom logic, added widget icon
* array and object accordian with border/background styling
* minor change
* disabled states for array and objects
* default value minor fix
* form level styles
* modified logic for isDisabled for array and object, added disabledWhenInvalid, exposed isValid to fieldState for text input, removed useDisableChildren
* added isValid for all field types
* fixed reset to default values
* debounce form values update
* minor change
* minor change
* fix crash - source data change multi-select to array, fix crash - change of options
* fix positioning
* detect date type in source data
* fix crash - when object is passed to regex input field
* fixed default sourceData path for fields
* accodion keep children mounted on collapse
* jest test for schemaParser
* widget/helper and useRegisterFieldInvalid test
* tests for property config helper and generatePanelPropertyConfig
* fix input field validation not appearing
* fix date field type detection
* rename data -> formData
* handle null/undefined field value change in sourceData
* added null/undefined as valid values for defaultValue text field
* auto detect email field
* set formData default value on initial load
* switch field inline positioning
* field margin fix for row direction
* select full width
* fiex date field default value - out of range
* fix any field type to array
* array default value logic change
* base cypress test changes
* initial json form render cy test
* key sanitization
* fix fieldState update logic
* required design, object/array background color, accordion changes, fix - add new custom field
* minor change
* cypress tests
* fix date formatted value, field state cypress test
* cypress - field properties test and fixes
* rename test file
* fix accessort change to blank value, cypress tests
* fix array field default value for modified accessor
* minor fix
* added animate loading
* fix empty state, add new custom field
* test data fix
* fix warnings
* fix timePrecision visibility
* button styling
* ported input v2
* fix jest tests
* fix cypress tests
* perf changes
* perf improvement
* added comments
* multiselect changes
* input field perf refactor
* array field, object field refactor performance
* checkbox field refactor
* refectored date, radio, select and switch
* fixes
* test fixes
* fixes
* minor fix
* rename field renderer
* remove tracked fieldRenderer field
* cypress test fixes
* cypress changes
* array default value fixes
* arrayfield passedDefaultValue
* auto enabled JS mode for few properties, reverted swith and date property controls
* cypress changes
* added widget sniping mode and fixed object passedDefaultValue
* multiselect v2
* select v2
* fix jest tests
* test fixes
* field limit
* rename field type dropdown texts
* field type changes fixes
* jest fixes
* loading state submit button
* default source data for new widget
* modify limit message
* multiseelct default value changes and cypress fix
* select default value
* keep default value intact on field type change
* TextTable cypress text fix
* review changes
* fixed footer changes
* collapse styles section by default
* fixed footer changes
* form modes
* custom field key rentention
* fixed footer fix in view mode
* non ascii characters
* fix meta merge in dataTreeWidget
* minor fixes
* rename useRegisterFieldInvalid.ts -> useRegisterFieldValidity.ts
* modified dependency injection into evaluated values
* refactored fixedfooter logic
* minor change
* accessor update
* minor change
* fixes
* QA fixes date field, scroll content
* fix phone number field, removed visiblity option from array item
* fix sourceData autocomplete
* reset logic
* fix multiselect reset
* form values hydration on widget drag
* code review changes
* reverted order of merge dataTreeWidget
* fixes
* added button titles, fixed hydration issue
* default value fixes
* upgraded react hook form, modified array-level/field-level default value logic
* fixed select validation
* added icon entity explorer, modified icon align control
* modify accessor validation for mongo db _id
* update email field regex
* review changes
* explicitly handle empty source data validation
2022-03-24 07:13:25 +00:00
|
|
|
deepObj: {
|
|
|
|
|
level1: {
|
|
|
|
|
metaValue: 10,
|
|
|
|
|
},
|
|
|
|
|
},
|
2021-04-21 14:34:25 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const getMetaProps = jest.spyOn(
|
|
|
|
|
WidgetFactory,
|
|
|
|
|
"getWidgetMetaPropertiesMap",
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
getMetaProps.mockReturnValueOnce({
|
|
|
|
|
text: true,
|
|
|
|
|
isDirty: true,
|
|
|
|
|
});
|
|
|
|
|
|
2022-04-12 13:09:26 +00:00
|
|
|
const bindingPaths = {
|
|
|
|
|
defaultText: EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
placeholderText: EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
regex: EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
resetOnSubmit: EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
isVisible: EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
isRequired: EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
isDisabled: EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
errorMessage: EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
};
|
|
|
|
|
|
2023-03-20 11:04:02 +00:00
|
|
|
const expectedData = {
|
2021-04-21 14:34:25 +00:00
|
|
|
value: "{{Input1.text}}",
|
|
|
|
|
isDirty: true,
|
|
|
|
|
isFocused: false,
|
|
|
|
|
isValid: "{{true}}",
|
|
|
|
|
text: "Tester",
|
|
|
|
|
bottomRow: 0,
|
|
|
|
|
isLoading: false,
|
|
|
|
|
leftColumn: 0,
|
|
|
|
|
parentColumnSpace: 0,
|
|
|
|
|
parentRowSpace: 0,
|
|
|
|
|
rightColumn: 0,
|
2022-12-02 12:45:11 +00:00
|
|
|
renderMode: RenderModes.CANVAS,
|
2021-04-21 14:34:25 +00:00
|
|
|
version: 0,
|
2022-12-02 12:45:11 +00:00
|
|
|
topRow: 0,
|
2021-04-21 14:34:25 +00:00
|
|
|
widgetId: "123",
|
|
|
|
|
widgetName: "Input1",
|
|
|
|
|
ENTITY_TYPE: ENTITY_TYPE.WIDGET,
|
2022-01-28 11:10:05 +00:00
|
|
|
defaultText: "",
|
2023-03-20 11:04:02 +00:00
|
|
|
type: "INPUT_WIDGET_V2",
|
feat: JSON Form widget (#8472)
* initial layout
* updated parser to support nested array
* array field rendering
* changes
* ts fix
* minor revert FormWidget
* modified schema structure
* select and switch fields
* added checkbox field
* added RadioGroupField
* partial DateField and defaults, typing refactoring
* added label and field type change
* minor ts changes
* changes
* modified widget/utils for nested panelConfig, modified schema to object approach
* array/object label support
* hide field configuration when children not present
* added tooltip
* field visibility option
* disabled state
* upgraded tslib, form initial values
* custom field configuration - add/hide/edit
* field configuration - label change
* return input when field configuration reaches max depth
* minor changes
* form - scroll, fixedfooter, enitity defn and other minior changes
* form title
* unregister on unmount
* fixes
* zero state
* fix field padding
* patched updating form values, removed linting warnings
* configured action buttons
* minor fix
* minor change
* property pane - sort fields in field configuration
* refactor include all properties
* checkbox properties
* date properties
* refactor typings and radio group properties
* switch, multselect, select, array, object properties
* minor changes
* default value
* ts fixes
* checkbox field properties implementation
* date field prop implementation
* switch field
* select field and fix deep nested meta properties
* multiselect implementation
* minor change
* input field implementation
* fix position jump on field type change
* initial accordian
* field state property and auto-complete of JSONFormComputeControl
* merge fixes
* renamed FormBuilder to JSONForm
* source data validation minor change
* custom field default value fix
* Editable keys for custom field
* minor fixes
* replaced useFieldArray with custom logic, added widget icon
* array and object accordian with border/background styling
* minor change
* disabled states for array and objects
* default value minor fix
* form level styles
* modified logic for isDisabled for array and object, added disabledWhenInvalid, exposed isValid to fieldState for text input, removed useDisableChildren
* added isValid for all field types
* fixed reset to default values
* debounce form values update
* minor change
* minor change
* fix crash - source data change multi-select to array, fix crash - change of options
* fix positioning
* detect date type in source data
* fix crash - when object is passed to regex input field
* fixed default sourceData path for fields
* accodion keep children mounted on collapse
* jest test for schemaParser
* widget/helper and useRegisterFieldInvalid test
* tests for property config helper and generatePanelPropertyConfig
* fix input field validation not appearing
* fix date field type detection
* rename data -> formData
* handle null/undefined field value change in sourceData
* added null/undefined as valid values for defaultValue text field
* auto detect email field
* set formData default value on initial load
* switch field inline positioning
* field margin fix for row direction
* select full width
* fiex date field default value - out of range
* fix any field type to array
* array default value logic change
* base cypress test changes
* initial json form render cy test
* key sanitization
* fix fieldState update logic
* required design, object/array background color, accordion changes, fix - add new custom field
* minor change
* cypress tests
* fix date formatted value, field state cypress test
* cypress - field properties test and fixes
* rename test file
* fix accessort change to blank value, cypress tests
* fix array field default value for modified accessor
* minor fix
* added animate loading
* fix empty state, add new custom field
* test data fix
* fix warnings
* fix timePrecision visibility
* button styling
* ported input v2
* fix jest tests
* fix cypress tests
* perf changes
* perf improvement
* added comments
* multiselect changes
* input field perf refactor
* array field, object field refactor performance
* checkbox field refactor
* refectored date, radio, select and switch
* fixes
* test fixes
* fixes
* minor fix
* rename field renderer
* remove tracked fieldRenderer field
* cypress test fixes
* cypress changes
* array default value fixes
* arrayfield passedDefaultValue
* auto enabled JS mode for few properties, reverted swith and date property controls
* cypress changes
* added widget sniping mode and fixed object passedDefaultValue
* multiselect v2
* select v2
* fix jest tests
* test fixes
* field limit
* rename field type dropdown texts
* field type changes fixes
* jest fixes
* loading state submit button
* default source data for new widget
* modify limit message
* multiseelct default value changes and cypress fix
* select default value
* keep default value intact on field type change
* TextTable cypress text fix
* review changes
* fixed footer changes
* collapse styles section by default
* fixed footer changes
* form modes
* custom field key rentention
* fixed footer fix in view mode
* non ascii characters
* fix meta merge in dataTreeWidget
* minor fixes
* rename useRegisterFieldInvalid.ts -> useRegisterFieldValidity.ts
* modified dependency injection into evaluated values
* refactored fixedfooter logic
* minor change
* accessor update
* minor change
* fixes
* QA fixes date field, scroll content
* fix phone number field, removed visiblity option from array item
* fix sourceData autocomplete
* reset logic
* fix multiselect reset
* form values hydration on widget drag
* code review changes
* reverted order of merge dataTreeWidget
* fixes
* added button titles, fixed hydration issue
* default value fixes
* upgraded react hook form, modified array-level/field-level default value logic
* fixed select validation
* added icon entity explorer, modified icon align control
* modify accessor validation for mongo db _id
* update email field regex
* review changes
* explicitly handle empty source data validation
2022-03-24 07:13:25 +00:00
|
|
|
deepObj: {
|
|
|
|
|
level1: {
|
|
|
|
|
metaValue: 10,
|
|
|
|
|
},
|
|
|
|
|
},
|
2022-12-02 12:45:11 +00:00
|
|
|
meta: {
|
|
|
|
|
text: "Tester",
|
|
|
|
|
isDirty: true,
|
|
|
|
|
deepObj: {
|
|
|
|
|
level1: {
|
|
|
|
|
metaValue: 10,
|
|
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
},
|
2021-04-21 14:34:25 +00:00
|
|
|
};
|
|
|
|
|
|
2023-03-20 11:04:02 +00:00
|
|
|
const expectedConfig = {
|
|
|
|
|
ENTITY_TYPE: ENTITY_TYPE.WIDGET,
|
|
|
|
|
widgetId: "123",
|
|
|
|
|
bindingPaths,
|
|
|
|
|
reactivePaths: {
|
|
|
|
|
...bindingPaths,
|
|
|
|
|
isDirty: EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
isFocused: EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
isValid: EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
text: EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
value: EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
"meta.text": EvaluationSubstitutionType.TEMPLATE,
|
|
|
|
|
},
|
|
|
|
|
|
|
|
|
|
triggerPaths: {
|
|
|
|
|
onSubmit: true,
|
|
|
|
|
onTextChanged: true,
|
|
|
|
|
},
|
|
|
|
|
type: "INPUT_WIDGET_V2",
|
|
|
|
|
validationPaths: {
|
|
|
|
|
defaultText: { type: ValidationTypes.TEXT },
|
|
|
|
|
errorMessage: { type: ValidationTypes.TEXT },
|
|
|
|
|
isDisabled: { type: ValidationTypes.BOOLEAN },
|
|
|
|
|
isRequired: { type: ValidationTypes.BOOLEAN },
|
|
|
|
|
isVisible: { type: ValidationTypes.BOOLEAN },
|
|
|
|
|
placeholderText: { type: ValidationTypes.TEXT },
|
|
|
|
|
regex: { type: ValidationTypes.REGEX },
|
|
|
|
|
resetOnSubmit: { type: ValidationTypes.BOOLEAN },
|
|
|
|
|
},
|
|
|
|
|
dynamicBindingPathList: [
|
|
|
|
|
{
|
|
|
|
|
key: "isValid",
|
|
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
key: "value",
|
|
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
logBlackList: {
|
|
|
|
|
isValid: true,
|
|
|
|
|
value: true,
|
|
|
|
|
},
|
|
|
|
|
propertyOverrideDependency: {
|
|
|
|
|
text: {
|
|
|
|
|
DEFAULT: "defaultText",
|
|
|
|
|
META: "meta.text",
|
|
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
defaultMetaProps: ["text", "isDirty", "isFocused"],
|
|
|
|
|
defaultProps: {
|
|
|
|
|
text: "defaultText",
|
|
|
|
|
},
|
|
|
|
|
overridingPropertyPaths: {
|
|
|
|
|
defaultText: ["text", "meta.text"],
|
|
|
|
|
"meta.text": ["text"],
|
|
|
|
|
},
|
|
|
|
|
privateWidgets: {},
|
|
|
|
|
isMetaPropDirty: true,
|
|
|
|
|
};
|
|
|
|
|
|
2021-04-21 14:34:25 +00:00
|
|
|
const result = generateDataTreeWidget(widget, widgetMetaProps);
|
2023-03-20 11:04:02 +00:00
|
|
|
expect(result.unEvalEntity).toStrictEqual(expectedData);
|
|
|
|
|
expect(result.configEntity).toStrictEqual(expectedConfig);
|
2021-04-21 14:34:25 +00:00
|
|
|
});
|
|
|
|
|
});
|